Add Tabs component #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yale
reviewed
May 3, 2017
src/components/Tabs/Tabs.jsx
Outdated
| selectedIndex: index | ||
| }); | ||
| if (this.props.onClick) { | ||
| this.props.onClick(index); |
There was a problem hiding this comment.
i'm wondering if we can somehow give a key to each tab, so that what's passed to the handler is like, 'my_tab' and 'another_tab' instead of 0 or 1. that would be less fragile if we were to add new tabs or reorder existing ones.
|
the style & component in general look good, however see my comment about using some sort of |
|
whoops didn't mean to close, sorry! |
yale
reviewed
May 3, 2017
src/components/Tabs/Tabs.jsx
Outdated
| constructor(props) { | ||
| super(props); | ||
|
|
||
| let selectedIndex = _.findIndex(props.items, item => item.selected); |
There was a problem hiding this comment.
minor: maybe the lodash shorthand exists for this: _.findIndex(props.items, 'selected')
yale
approved these changes
May 3, 2017
yale
approved these changes
May 3, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this pretty minimal for now — just a way to pass an array of strings and a single callback for all of them that's being passed an index of a selected tab.
Added support for the keyboard as well since it's not too complicated although not sure how important that is at the moment. It'd be nice to add ARIA roles as well but that'd probably be overkill right now.