Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macos stable release not found #2176

Closed
lispyclouds opened this issue Jun 25, 2022 · 7 comments
Closed

Macos stable release not found #2176

lispyclouds opened this issue Jun 25, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@lispyclouds
Copy link

lispyclouds commented Jun 25, 2022

What Operating System(s) are you seeing this problem on?

macOS

WezTerm version

20220624-141144-bd1b7c5d

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

No, this issue is on the latest stable version.

Describe the bug

The mac installed seems to be unreleased and the brew install --cask wez/wezterm/wezterm fails with a 404 error.

To Reproduce

Try running brew install --cask wez/wezterm/wezterm

Configuration

no config

Expected Behavior

wezterm is successfully installed.

Logs

No response

Anything else?

Thanks a lot for making this, this is my absolute favourite terminal! ❤️

@lispyclouds lispyclouds added the bug Something isn't working label Jun 25, 2022
@lispyclouds lispyclouds changed the title Macos release not found Macos stable release not found Jun 25, 2022
@wez
Copy link
Owner

wez commented Jun 25, 2022

Can you include the full 404 error message?

@lispyclouds
Copy link
Author

Here it is:

$ brew install --cask wez/wezterm/wezterm

==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).
Running `brew update --auto-update`...

You have 2 outdated formulae installed.
You can upgrade them with brew upgrade
or list them with brew outdated.

==> Caveats
Cask wezterm related executables like 'wezterm', 'wezterm-gui',
'wezterm-mux-server', are linked into
  /usr/local/bin/    for x86 Mac,
  /opt/homebrew/bin/ for M1 Mac.

Removal of them is ensured by 'brew uninstall --cask wezterm'.

==> Downloading https://github.com/wez/wezterm/releases/download/20220624-141144-bd1b7c5d/WezTerm-macos-20220624-14114
curl: (22) The requested URL returned error: 404

Error: Download failed on Cask 'wezterm' with message: Download failed: https://github.com/wez/wezterm/releases/download/20220624-141144-bd1b7c5d/WezTerm-macos-20220624-141144-bd1b7c5d.zip

@lispyclouds
Copy link
Author

I think it should be there in the releases page right? I don't think I can see it here ?

@wez
Copy link
Owner

wez commented Jun 25, 2022

Weird, looks like there are a number of builds labelled nightly there, but they should be release builds

wez added a commit that referenced this issue Jun 25, 2022
dc728b3 introduced some non-determinism
by mutating the global TARGETS list.

The result is, depending on iteration order, the generated jobs
may inherit the env from earlier jobs.

Notably, if the tag job inherit the schedule reason from a continuous
job, they'll upload assets with an incorrect filename.

This commit restores the determinism by forcing each iteration
of the generation loop to make a deep copy of the statically
defined information in TARGETS.

While we're at it, ensure that the list of env vars is sorted
to avoid non-determinism there as well.

refs: #2176
@wez
Copy link
Owner

wez commented Jun 25, 2022

I renamed the assets with the wrong names and updated the script that generated the workflows to (hopefully!) resolve this for the next tag.
Please try again and let me know if it is working now!

@lispyclouds
Copy link
Author

Works perfectly now! Thanks a lot for the quick fix! 🚀

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants