Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing vault status for some primes #504

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

SlayerOrnstein
Copy link
Member

What did you fix?

This fixes vault missing for some prime warframes. i.e. Nidus Prime was missing vault due to data not being available on ogg. Vault status is now retrieved from the wikia and fallsback to ogg.


Reproduction steps


Evidence/screenshot/link to line

image

Considerations

  • Does this contain a new dependency? Yes
  • Does this introduce opinionated data formatting or manual data entry? No?
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? No
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Bug Fix

@SlayerOrnstein SlayerOrnstein requested a review from a team as a code owner January 5, 2024 05:40
@SlayerOrnstein SlayerOrnstein requested a review from AyAyEm January 5, 2024 05:40
Copy link
Member

@AyAyEm AyAyEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the code but good job so far, i will do the review of the data if @TobiTenno approve the idea of adding more wiki dependency

@AyAyEm AyAyEm requested a review from TobiTenno January 5, 2024 12:00
Copy link
Member

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine overall, just some weird formatting on vs code

@AyAyEm
Copy link
Member

AyAyEm commented Jan 6, 2024

All the pertinent data for this PR

Removed the wikiaThumbnail from it
itemsNew.json 6256551
itemsOld.json a1f9f18

vaultData.json
wikia.json

@AyAyEm
Copy link
Member

AyAyEm commented Jan 6, 2024

is it possible to get the vaulted status from relics from wikia? if so would you be willing to do the work in this pr @SlayerOrnstein ? (you've already done alot this is totally optional) if so we could fix #496

@SlayerOrnstein
Copy link
Member Author

SlayerOrnstein commented Jan 6, 2024

Hmm it would be but I think that's a feature better suited for warframe-relics then add that into items

I think relics already have a vault flag since @TobiTenno set that up with warframe-relics.

https://github.com/WFCD/warframe-items/blob/a1f9f1811792641af8bbd96d4b0216c13ebf9afb/build/parser.mjs#L997C35-L997C35

Copy link
Member

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you're gonna add sentinels & archwings, you should upgrade this to a feat, or do those in a separate PR.

@SlayerOrnstein
Copy link
Member Author

if you're gonna add sentinels & archwings, you should upgrade this to a feat, or do those in a separate PR.

Gonna have to be a feature then because without archwings building breaks and without sentinels data is removed

@SlayerOrnstein SlayerOrnstein changed the title fix: missing vault status for some primes feat: add wikia as a fallback for vaulted flag Jan 8, 2024
@TobiTenno
Copy link
Member

if you're gonna add sentinels & archwings, you should upgrade this to a feat, or do those in a separate PR.

Gonna have to be a feature then because without archwings building breaks and without sentinels data is removed

aren't both of those only because you added those to being checked in the wiki updates?

those both seem like things that should be in their own features...

@SlayerOrnstein
Copy link
Member Author

if you're gonna add sentinels & archwings, you should upgrade this to a feat, or do those in a separate PR.

Gonna have to be a feature then because without archwings building breaks and without sentinels data is removed

aren't both of those only because you added those to being checked in the wiki updates?

those both seem like things that should be in their own features...

Because Warframes and Archwings are under the same category it would try to look for Odonata Prime under warframes. I can if you want have it ignore Archwings in this PR and then add it back in a different PR with sentinels but I guess because I still have to check the category before calling wikiaItem I would have to ignore sentinels and possible still end up removing vault fields from sentinels

@SlayerOrnstein SlayerOrnstein changed the title feat: add wikia as a fallback for vaulted flag fix: missing vault status for some primes Jan 8, 2024
@SlayerOrnstein
Copy link
Member Author

So I'll make this one depend on #506

@SlayerOrnstein SlayerOrnstein reopened this Jan 8, 2024
@SlayerOrnstein SlayerOrnstein force-pushed the master branch 5 times, most recently from cfc5ac0 to 51980b6 Compare January 17, 2024 19:35
@TobiTenno
Copy link
Member

i see 3 things that should not be in the PR

auto-merge was automatically disabled January 31, 2024 05:10

Head branch was pushed to by a user without write access

@TobiTenno TobiTenno requested a review from AyAyEm January 31, 2024 18:02
Copy link
Member

@AyAyEm AyAyEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
vaulted.csv

@TobiTenno TobiTenno merged commit 29460cc into WFCD:master Feb 2, 2024
8 checks passed
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 1.1261.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants