-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing vault status for some primes #504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed the code but good job so far, i will do the review of the data if @TobiTenno approve the idea of adding more wiki dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine overall, just some weird formatting on vs code
All the pertinent data for this PR Removed the wikiaThumbnail from it |
is it possible to get the vaulted status from relics from wikia? if so would you be willing to do the work in this pr @SlayerOrnstein ? (you've already done alot this is totally optional) if so we could fix #496 |
I think relics already have a vault flag since @TobiTenno set that up with warframe-relics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you're gonna add sentinels & archwings, you should upgrade this to a feat, or do those in a separate PR.
Gonna have to be a feature then because without archwings building breaks and without sentinels data is removed |
aren't both of those only because you added those to being checked in the wiki updates? those both seem like things that should be in their own features... |
Because Warframes and Archwings are under the same category it would try to look for Odonata Prime under warframes. I can if you want have it ignore Archwings in this PR and then add it back in a different PR with sentinels but I guess because I still have to check the category before calling |
So I'll make this one depend on #506 |
cfc5ac0
to
51980b6
Compare
i see 3 things that should not be in the PR |
a2924e5
to
23d31a7
Compare
Head branch was pushed to by a user without write access
703c0ac
to
715ca31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
vaulted.csv
🎉 This PR is included in version 1.1261.20 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What did you fix?
This fixes
vault
missing for some prime warframes. i.e. Nidus Prime was missingvault
due to data not being available on ogg. Vault status is now retrieved from the wikia and fallsback to ogg.Reproduction steps
Evidence/screenshot/link to line
Considerations