Skip to content

Conversation

Aaliya-Ali
Copy link
Contributor

Proposed Changes

  • Replaced the GridView with a MasonryGridView in the Gallery Screen

Please check that the PR fulfills these requirements

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.md

@rolandgeider rolandgeider linked an issue Oct 4, 2022 that may be closed by this pull request
@rolandgeider
Copy link
Member

FYI, I have approved the PR so that it will count towards hacktoberfest

@Aaliya-Ali
Copy link
Contributor Author

Thanks for approving my PR. Does an approved PR mean it is getting merged for sure?
Actually, I want to make an actual contribution(although small), not just for the sake of completing Hacktoberfest. So, I wanted to make sure it gets merged. Let me know if there's anything I can do to have it merged.

@rolandgeider
Copy link
Member

You already did contribute :)

Basically what we could still figure out are the tests. It also shouldn't be that we invest three times as much fixing this than in implementing the feature so if we can't come up with any ideas, we can just mark the test as skipped and open an issue so this doesn't get lost

@Aaliya-Ali
Copy link
Contributor Author

Makes sense. Thanks again :)

@rolandgeider
Copy link
Member

All green now, thanks!

@rolandgeider rolandgeider merged commit 1dd9848 into wger-project:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add masonry type interface to gallery
2 participants