Skip to content

Conversation

AmanNegi
Copy link
Contributor

Proposed Changes

  • Added a check during Login and Signup to ensure the user is using a valid app version. If the user login is successful but the app version is not supported the user is now directed to the Update App page.

  • The Error dialog displayed was showing the error in an uneasy fashion, I modified the error dialog as well. Changes I made in Error Dialog are:

    • Made the Errors alignment to CrossAxisAlignment.start.
    • The key property of the error was coming all lowercase, I added a few lines of code to ensure the first letter was capitalized to ensure the error was more formal and readable.
  • Now the user login process is much more streamlined with the loading indicator, error handling dialog and app version validator.

Related Issues (if applicable)
This PR is regarding issue #101

Please check that the PR fulfills these requirements

  • [✔] Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • [✔ ] Tests for the changes have been added (for bug fixes / features)
  • [ ✔] Added yourself to AUTHORS.md

@rolandgeider
Copy link
Member

Thanks for the PR, I'll try to test it as soon as I can

@AmanNegi
Copy link
Contributor Author

Great! 🍀😊

Can I help you with the testing? Like providing you APK or recording the authentication process.

@rolandgeider
Copy link
Member

thanks, but I'll manage, just need to find a quiet evening :)

@AmanNegi
Copy link
Contributor Author

Okay great, let me know :)

@rolandgeider
Copy link
Member

Yes, this is indeed an improvement, thanks!

@rolandgeider rolandgeider linked an issue Oct 14, 2022 that may be closed by this pull request
@AmanNegi
Copy link
Contributor Author

Great! 🤗
Will this PR be merged?

@rolandgeider rolandgeider merged commit bf88275 into wger-project:master Oct 15, 2022
@rolandgeider
Copy link
Member

merged, thanks! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor login page
2 participants