Fixes validation issue in auth screen #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiggy9
commented
May 12, 2023
There was a problem hiding this comment.
Hello,
I've submitted a pull request that fixes the validation issue in the auth_screen.dart file. The changes have been tested and meet the requirements outlined in the pull request template.
Could you please review and merge this pull request at your earliest convenience? Let me know if you have any questions or concerns.
Thank you for your time and consideration.
Jiggy9
commented
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
-This pull request fixes an issue in the
auth_screen.dartfile where the validation for an empty value was not properly handled. By switching the order of the if statements in the validator function, the validation now correctly checks for an empty value before checking for invalid characters using a regular expression.-This fix ensures that the validation works as intended and provides better error messaging to the user when an invalid value is entered.
-Thank you for considering this pull request. Let me know if you have any further questions or concerns.