Skip to content

Conversation

M123-dev
Copy link
Contributor

@M123-dev M123-dev commented Oct 1, 2021

Fixes #86

The PR turned out a bit bigger than I would have hoped.

Since I had to intervene the lint settings a bit by hand I left out a few important things for now (marked with "# to be changed"), we can take care of those in future PR's.

There were 3 true but small errors, which would have led to problems, I fixed them, otherwise there were no functional changes.

@rolandgeider
Copy link
Member

wow, you weren't kidding! In any case, thanks a lot for taking the time, I'll merge this tomorrow

@M123-dev
Copy link
Contributor Author

M123-dev commented Oct 2, 2021

I have to admit though, not everything was directly forced by flutter_lints, a few things also came through the linting rules

I just had a look why the tests fail, but couldn't reproduce it. Locally all the tests pass

@rolandgeider
Copy link
Member

it's always the same test, it sometimes fails on github

(super.noSuchMethod(Invocation.method(#deleteRequest, [url, id]),
returnValue: Future<_i3.Response>.value(_FakeResponse_3())) as _i6.Future<_i3.Response>);
@override
String toString() => super.toString();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, all the foo.mocks.dart files are generated, so this will come back the next time we start the build runner

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh thanks I completely missed that, haven't really looked at the file names

@rolandgeider rolandgeider merged commit 681470b into wger-project:master Oct 2, 2021
@M123-dev M123-dev deleted the flutter_lints-package branch October 2, 2021 11:23
@M123-dev M123-dev mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use flutter_lints package
2 participants