Correct Preset Time In Session Form #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es for initialTime of TimePicker and setting them as well
rolandgeider
reviewed
Oct 6, 2021
…alize timeStart/end
…TomerPacific/flutter into fix/preset-time-session-form-31
rolandgeider
approved these changes
Oct 7, 2021
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When a user chooses a start/end time at the end of the gym mode, the time will always be the same when trying to edit. This happened because of two reasons:
The fix adds a default time to session's timeStart/end and also corrects the behavior of setting these fields appropriately.
Related Issues (if applicable)
Fixes #31
Please check that the PR fulfills these requirements