Skip to content

Conversation

infiniteoverflow
Copy link
Contributor

Proposed Changes

  • I have added a setState callback to set the loading state to false inside the catch block. This way every time an Exception or an error is caught, it will stop the circular loader.

Related Issues (if applicable)

Please check that the PR fulfills these requirements

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.rst

@infiniteoverflow
Copy link
Contributor Author

infiniteoverflow commented Oct 7, 2021

Attaching a video of the working after the bug fix:

Screen.Recording.2021-10-07.at.9.23.17.PM.mov

@rolandgeider
Copy link
Member

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular Progress Indicator dosen't stop if Exception occurs during Auth
2 participants