UTF-8 support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new charset parameter in controller, stored in a new static property in the environment, and handled the endpoint URL taking this into account
Added a new charset parameter in environment, stored in a new static property, and handled the gateway URL taking this into account
The charset, as it has a default value, should not be set in the constructor, but with a setCharset method, that will be used only when needed.
xarem
added a commit
that referenced
this pull request
Oct 17, 2015
feat(charset): adding UTF-8 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostFinance has two gateways depending on the charset, and the library would let connect to one of them only, which assumes ISO 8859-1. This commit should let access the gateway handling UTF-8.
Main changes are :
$CHARSETproperty in the environmentThis has been made quickly and in order not to cause backwards compatibility, therefore the
$CHARSET– used in the staticEnvironmentInterface::getGatewayUrl()method – is static as well