Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use commonAncestorContainer in concept-range-clone #56

Open
Ms2ger opened this issue Jul 16, 2015 · 3 comments
Open

Use commonAncestorContainer in concept-range-clone #56

Ms2ger opened this issue Jul 16, 2015 · 3 comments
Labels
topic: ranges

Comments

@Ms2ger
Copy link
Member

Ms2ger commented Jul 16, 2015

https://dom.spec.whatwg.org/#concept-range-clone

    1. Let common ancestor be original start node.
    1. While common ancestor is not an inclusive ancestor of original end node, set common ancestor to its own parent.

This is range's commonAncestorContainer.
@Ms2ger Ms2ger mentioned this issue Jul 16, 2015
Merged
@annevk
Copy link
Member

annevk commented Jul 17, 2015

I really wish https://www.w3.org/Bugs/Public/show_bug.cgi?id=27301#c2 would be fixed so it'd be safe to reuse algorithms.

@annevk
Copy link
Member

annevk commented Jul 17, 2015

Now I'd have to introduce a new concept...

@annevk annevk added the good first issue Ideal for someone new to a WHATWG standard or software project label Nov 11, 2015
@annevk annevk mentioned this issue Dec 17, 2017
Open
annevk added a commit that referenced this issue Mar 16, 2018
@annevk
Editorial: add range's common ancestor
327c398 
Fixes #56.
@annevk annevk mentioned this issue Mar 16, 2018
Closed
@annevk
Copy link
Member

annevk commented Mar 18, 2018

It's not entirely clear to me that this change is correct if mutation events continue to exist.

@annevk annevk added topic: ranges and removed good first issue Ideal for someone new to a WHATWG standard or software project labels Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: ranges
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ms2ger @annevk