Remove more types from document.createEvent() #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes whatwg#362. All of the removed event types except WheelEvent are unsupported or are supported but cannot be properly initialized in Blink, Gecko, and WebKit. WheelEvent is supported in WebKit with a vendor-prefixed initializer, but WebKit is willing to try dropping it.
ayg
added a commit
to ayg/web-platform-tests
that referenced
this pull request
Aug 6, 2017
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 7, 2017
|
(FWIW, there's no longer a need for you to fork this repository. You should be able to create branches directly on whatwg/dom.) |
|
Is that preferred? My GitHub workflow in general is to fork, and it's easier for me to not have a different workflow for different repos, but if there's some advantage I could do it. |
|
It's a little easier for me to push fixups to local branches, but that's about it. No strong preference, just thought it might be more convenient for you to have less repositories to track. |
|
Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1388069 |
|
Actually, that bug is the opposite (adding a type that we don't yet support). Removing the two we do support that were removed in this commit is here: https://bugzilla.mozilla.org/show_bug.cgi?id=1388119 (It turns out ErrorEvent support was added to Firefox six months ago to match the spec, but now I think we should remove it again given that Chrome is willing to drop it.) |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 8, 2017
…t"); r=smaug They were just dropped from the spec: whatwg/dom#362 whatwg/dom#489 ErrorEvent we never supported anyway until it was added recently to match the spec. PopStateEvent is not supported by WebKit, Blink is planning to try dropping support, our telemetry shows usage is basically zero, and we never supported any way to initialize it anyway. The changes to Document-createEvent.html and Document-createEvent.js are taken from upstream. The other wpt changes are new in this commit. MozReview-Commit-ID: A6GzhLwL08l --HG-- extra : rebase_source : 4bdcd605b179ea787985845e9b1c53f76ebc179a
weilonge
pushed a commit
to weilonge/gecko
that referenced
this pull request
Aug 8, 2017
…t"); r=smaug They were just dropped from the spec: whatwg/dom#362 whatwg/dom#489 ErrorEvent we never supported anyway until it was added recently to match the spec. PopStateEvent is not supported by WebKit, Blink is planning to try dropping support, our telemetry shows usage is basically zero, and we never supported any way to initialize it anyway. The changes to Document-createEvent.html and Document-createEvent.js are taken from upstream. The other wpt changes are new in this commit. MozReview-Commit-ID: A6GzhLwL08l
jgraham
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 11, 2017
They were just dropped from the spec: whatwg/dom#362 whatwg/dom#489 ErrorEvent we never supported anyway until it was added recently to match the spec. PopStateEvent is not supported by WebKit, Blink is planning to try dropping support, our telemetry shows usage is basically zero, and we never supported any way to initialize it anyway. The changes to Document-createEvent.html and Document-createEvent.js are taken from upstream. The other wpt changes are new in this commit. MozReview-Commit-ID: A6GzhLwL08l Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1388119 [ci skip]
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Aug 14, 2017
…t"); r=smaug They were just dropped from the spec: whatwg/dom#362 whatwg/dom#489 ErrorEvent we never supported anyway until it was added recently to match the spec. PopStateEvent is not supported by WebKit, Blink is planning to try dropping support, our telemetry shows usage is basically zero, and we never supported any way to initialize it anyway. The changes to Document-createEvent.html and Document-createEvent.js are taken from upstream. The other wpt changes are new in this commit. MozReview-Commit-ID: A6GzhLwL08l
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
Aug 15, 2017
…t"); r=smaug They were just dropped from the spec: whatwg/dom#362 whatwg/dom#489 ErrorEvent we never supported anyway until it was added recently to match the spec. PopStateEvent is not supported by WebKit, Blink is planning to try dropping support, our telemetry shows usage is basically zero, and we never supported any way to initialize it anyway. The changes to Document-createEvent.html and Document-createEvent.js are taken from upstream. The other wpt changes are new in this commit. MozReview-Commit-ID: A6GzhLwL08l
rachelandrew
pushed a commit
to rachelandrew/web-platform-tests
that referenced
this pull request
Nov 8, 2017
rachelandrew
pushed a commit
to rachelandrew/web-platform-tests
that referenced
this pull request
Nov 8, 2017
They were just dropped from the spec: whatwg/dom#362 whatwg/dom#489 ErrorEvent we never supported anyway until it was added recently to match the spec. PopStateEvent is not supported by WebKit, Blink is planning to try dropping support, our telemetry shows usage is basically zero, and we never supported any way to initialize it anyway. The changes to Document-createEvent.html and Document-createEvent.js are taken from upstream. The other wpt changes are new in this commit. MozReview-Commit-ID: A6GzhLwL08l Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1388119 [ci skip]
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…t"); r=smaug They were just dropped from the spec: whatwg/dom#362 whatwg/dom#489 ErrorEvent we never supported anyway until it was added recently to match the spec. PopStateEvent is not supported by WebKit, Blink is planning to try dropping support, our telemetry shows usage is basically zero, and we never supported any way to initialize it anyway. The changes to Document-createEvent.html and Document-createEvent.js are taken from upstream. The other wpt changes are new in this commit. MozReview-Commit-ID: A6GzhLwL08l UltraBlame original commit: b668f3429c7f1ec6da0df694e75dbebb6c59533a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…t"); r=smaug They were just dropped from the spec: whatwg/dom#362 whatwg/dom#489 ErrorEvent we never supported anyway until it was added recently to match the spec. PopStateEvent is not supported by WebKit, Blink is planning to try dropping support, our telemetry shows usage is basically zero, and we never supported any way to initialize it anyway. The changes to Document-createEvent.html and Document-createEvent.js are taken from upstream. The other wpt changes are new in this commit. MozReview-Commit-ID: A6GzhLwL08l UltraBlame original commit: b668f3429c7f1ec6da0df694e75dbebb6c59533a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…t"); r=smaug They were just dropped from the spec: whatwg/dom#362 whatwg/dom#489 ErrorEvent we never supported anyway until it was added recently to match the spec. PopStateEvent is not supported by WebKit, Blink is planning to try dropping support, our telemetry shows usage is basically zero, and we never supported any way to initialize it anyway. The changes to Document-createEvent.html and Document-createEvent.js are taken from upstream. The other wpt changes are new in this commit. MozReview-Commit-ID: A6GzhLwL08l UltraBlame original commit: b668f3429c7f1ec6da0df694e75dbebb6c59533a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362. All of the removed event types except WheelEvent are
unsupported or are supported but cannot be properly initialized in
Blink, Gecko, and WebKit. WheelEvent is supported in WebKit with a
vendor-prefixed initializer, but WebKit is willing to try dropping it.
Preview | Diff