Fix logical error of filling fullscreenElements (3.12)

[ChangWanHong]

Closes: #144

---

Preview | Diff

[ChangWanHong]

CI tool emits similar log with my local "make deploy":

$ make deploy 
curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8555  100  8555    0     0   5684      0  0:00:01  0:00:01 --:--:--  5688
bash ./deploy.sh
Running a local deploy into fullscreen.spec.whatwg.org directory

Running deploy for commit: 23899b4442ba622c0024ce4f5c6f4b02c24f7fe2

Linting the source:
All good

Starting commit snapshot...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 31022    0   795  100 30227    383  14562  0:00:02  0:00:02 --:--:-- 14567
Error running preprocessor, returned code: 1.
LINK ERROR: Multiple possible 'browsing context' dfn refs for '/'.
Arbitrarily chose https://html.spec.whatwg.org/multipage/browsers.html#browsing-context
The following refs show up multiple times in their spec, in a way that Bikeshed can't distinguish between. Either create a manual link, or ask the spec maintainer to add disambiguating attributes (usually a for='' attribute to all of them).
spec:html; type:dfn; for:/; text:browsing context
  https://html.spec.whatwg.org/multipage/browsers.html#browsing-context
  https://html.spec.whatwg.org/multipage/window-object.html#window-bc
<a data-link-for="/" data-link-type="dfn" data-lt="browsing context">browsing context</a>
 ✘  Did not generate, due to fatal errorsMakefile:8: recipe for target 'deploy' failed
make: *** [deploy] Error 22

It's not from my patch, but should I resolve LINK ERROR first?

[annevk]

@ChangWanHong please don't worry about it. I'll try to fix this in the HTML Standard.

[annevk]

@ChangWanHong one thing you will need to do is sign https://participate.whatwg.org/agreement. Sorry for not making that clear earlier.

[foolip]

Thanks @ChangWanHong!

This error was introduced by me in #92, where I changed from first+prepend to first+append.

[ChangWanHong]

@annevk I signed as individual! Thanks for your help.

@foolip Thanks for your clear review! I hope this would be enough to merge.

[foolip]

Thanks @ChangWanHong!

@annevk I'll restart the Travis build, it should be fixed now right?

[ChangWanHong]

Hmm. It seems I'm not verified yet.

From signing page (after I signed),

...
Note that for now your submission is marked as unverified. The first time you submit a pull request to a standard, the editor will be responsible for verifying that your submission is accurate and representative. After that, future pull requests to the workstreams you chose to participate in will be automatically marked as approved.
...

@foolip Could you verify me please :)

[ChangWanHong]

@foolip One more thing, It is not relevant on this.. but I found some issue on your chromium code. PTAL: https://bugs.chromium.org/p/chromium/issues/detail?id=934150 . I couldn't CC'ing you, may be I don't have permission.

[foolip]

@ChangWanHong verified, and merging now. Thanks!

Commented on https://bugs.chromium.org/p/chromium/issues/detail?id=934150.