Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant recursive step of fullscreen element ready check #52

Merged
merged 1 commit into from
Sep 15, 2016

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 14, 2016

HTML's "allowed to use" only returns true if the document is in the
top-level browsing context, or if it's connected to it via any number of
iframes, all of which must be in a document to have nested browsing
contexts at all, so this final condition would always be true.

Fixes #50.

@annevk
Copy link
Member

annevk commented Sep 15, 2016

LGTM % update date before landing.

HTML's "allowed to use" only returns true if the document is in the
top-level browsing context, or if it's connected to it via any number of
iframes, all of which must be in a document to have nested browsing
contexts at all, so this final condition would always be true.

Fixes #50.
@foolip foolip force-pushed the simpler-ready-check branch from 50b8061 to 2f71e0b Compare September 15, 2016 14:30
@foolip
Copy link
Member Author

foolip commented Sep 15, 2016

Thanks for review, date changed in 9a75db6, merging.

@foolip foolip merged commit 484ca40 into master Sep 15, 2016
@foolip foolip deleted the simpler-ready-check branch September 15, 2016 14:30
foolip added a commit that referenced this pull request May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants