Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing xref for HostResolveImportedModule #8262

Closed
Ms2ger opened this issue Sep 5, 2022 · 3 comments · Fixed by #8326
Closed

Confusing xref for HostResolveImportedModule #8262

Ms2ger opened this issue Sep 5, 2022 · 3 comments · Fixed by #8326
Labels
good first issue Ideal for someone new to a WHATWG standard or software project topic: script

Comments

@Ms2ger
Copy link
Member

Ms2ger commented Sep 5, 2022

The definition of HostResolveImportedModule links to ES but implements the version in import assertions, which took me a minute to find. It would be better to link to the latter, I think.
@Jamesernator
Copy link

Jamesernator commented Sep 5, 2022 •
edited
Loading

Although this is a minor editorial change and would probably be fine, it's worth noting there is a proposal to be presented at the next TC39 meeting for refactoring all the host module hooks into a single hook, which which ultimately invalidate such a change anyway.

@domenic
Copy link
Member

domenic commented Sep 7, 2022

A PR from anyone fixing this would be very welcome in the meantime.

@domenic domenic added good first issue Ideal for someone new to a WHATWG standard or software project topic: script labels Sep 7, 2022
@katmlane
Copy link

I would be interested in picking up this small, soon obsolete contribution, in order to practice my PR on some open source code!

@gitcyco gitcyco mentioned this issue Sep 28, 2022
Merged
domenic pushed a commit that referenced this issue Sep 28, 2022
@gitcyco
Fix the link for HostResolveImportedModule
deaaa2c 
Since we are using the version from the Import Assertions spec, instead of the main JavaScript spec, we should link to that version.

Fixes #8262.
@domenic domenic mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project topic: script
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated link for HostResolveImportedModule gitcyco/html
4 participants
@Ms2ger @domenic @Jamesernator @katmlane