You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So at this point, we've created a new document for the navigation history entry's document state using hand wavy implementation defined methods for non-fetch scheme urls.
Steps 4, 5, 6, and 7 then set a "failure" boolean to true in an "otherwise" chain. But then step 8 breaks the otherwise chain with a simple "If failure is true, then ...". Then we have a new set of otherwise statements that attempt to access the response of navigationParams. However, if navigationParams is a non-fetch scheme navigation params, it doesn't have a response.
I assume that after executing step 3, we are supposed to skip down to steps 13 and 14 to set the "ever populated" flag on the document, run the completion steps, and bail from the algorithm.
I'm not sure what a nice way to structure this is, but it seems to me like the current structure doesn't work because of the break in the if/else chain with step 8.
The text was updated successfully, but these errors were encountered:
It seems out of place. Step 13 checks if entry's document state is non-null before manipulating it. As far as I can tell, there is no request in this algorithm at all.
...largely by rewriting everything that takes place inside the queued task. Compared to the previous version, this one has a clearer if/otherwise branching structure, avoids any early returns, and makes it easier to follow when exactly the entry's document state's document is set to a non-null value and what impact that has.
This fixes a couple logic bugs where final steps were not getting applied quite correctly for all branches. Closes#9767.
...largely by rewriting everything that takes place inside the queued task. Compared to the previous version, this one has a clearer if/otherwise branching structure, avoids any early returns, and makes it easier to follow when exactly the entry's document state's document is set to a non-null value and what impact that has.
This fixes a couple logic bugs where final steps were not getting applied quite correctly for all branches. Closes#9767.
in https://html.spec.whatwg.org/multipage/browsing-the-web.html#attempt-to-populate-the-history-entry's-document, step 6 starts a global task on the navigation and traversal task source
Step 3 of the global task steps says:
So at this point, we've created a new document for the navigation history entry's document state using hand wavy implementation defined methods for non-fetch scheme urls.
Steps 4, 5, 6, and 7 then set a "failure" boolean to true in an "otherwise" chain. But then step 8 breaks the otherwise chain with a simple "If failure is true, then ...". Then we have a new set of otherwise statements that attempt to access the response of navigationParams. However, if navigationParams is a non-fetch scheme navigation params, it doesn't have a response.
I assume that after executing step 3, we are supposed to skip down to steps 13 and 14 to set the "ever populated" flag on the document, run the completion steps, and bail from the algorithm.
I'm not sure what a nice way to structure this is, but it seems to me like the current structure doesn't work because of the break in the if/else chain with step 8.
The text was updated successfully, but these errors were encountered: