Fix "attempt to populate a history entry's document" #9902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...largely by rewriting everything that takes place inside the queued task. Compared to the previous version, this one has a clearer if/otherwise branching structure, avoids any early returns, and makes it easier to follow when exactly the entry's document state's document is set to a non-null value and what impact that has. This fixes a couple logic bugs where final steps were not getting applied quite correctly for all branches. Closes #9767.
domfarolino
reviewed
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...largely by rewriting everything that takes place inside the queued task. Compared to the previous version, this one has a clearer if/otherwise branching structure, avoids any early returns, and makes it easier to follow when exactly the entry's document state's document is set to a non-null value and what impact that has.
This fixes a couple logic bugs where final steps were not getting applied quite correctly for all branches. Closes #9767.
@ADKaster can you take a look? @kalenikaliaksandr might also be interested.
/browsing-the-web.html ( diff )