Remove <button type=menu> #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that buttons cannot trigger these menus, they only exist as context menus, so we should reflect that in the spec terminology too.
They can move into the context menu processing model section now, since they are not shared with <button type=menu>. And they can be renamed to be specifically about context menus, to avoid anyone thinking that they might be relevant to toolbar menus.
domenic
added
removal/deprecation
domenic
removed
the
needs tests
zcorpan
approved these changes
Feb 9, 2017
Zirro
added a commit
to Zirro/web-platform-tests
that referenced
this pull request
Dec 16, 2018
<button type="menu"> got removed in whatwg/html#2342 and this test was failing in all browsers.
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 16, 2018
<button type="menu"> got removed in whatwg/html#2342 and this test was failing in all browsers.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 23, 2019
…ect its removal, a=testonly Automatic update from web-platform-tests Update <button type="menu"> test to reflect its removal <button type="menu"> got removed in whatwg/html#2342 and this test was failing in all browsers. -- wpt-commits: 11971ac2161859001b861630338c0e47fee1b59a wpt-pr: 14545
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Jan 23, 2019
…ect its removal, a=testonly Automatic update from web-platform-tests Update <button type="menu"> test to reflect its removal <button type="menu"> got removed in whatwg/html#2342 and this test was failing in all browsers. -- wpt-commits: 11971ac2161859001b861630338c0e47fee1b59a wpt-pr: 14545
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…ect its removal, a=testonly Automatic update from web-platform-tests Update <button type="menu"> test to reflect its removal <button type="menu"> got removed in whatwg/html#2342 and this test was failing in all browsers. -- wpt-commits: 11971ac2161859001b861630338c0e47fee1b59a wpt-pr: 14545 UltraBlame original commit: 625c6152a40cbe9039035a9e598f582cd49412ae
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…ect its removal, a=testonly Automatic update from web-platform-tests Update <button type="menu"> test to reflect its removal <button type="menu"> got removed in whatwg/html#2342 and this test was failing in all browsers. -- wpt-commits: 11971ac2161859001b861630338c0e47fee1b59a wpt-pr: 14545 UltraBlame original commit: 625c6152a40cbe9039035a9e598f582cd49412ae
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…ect its removal, a=testonly Automatic update from web-platform-tests Update <button type="menu"> test to reflect its removal <button type="menu"> got removed in whatwg/html#2342 and this test was failing in all browsers. -- wpt-commits: 11971ac2161859001b861630338c0e47fee1b59a wpt-pr: 14545 UltraBlame original commit: 625c6152a40cbe9039035a9e598f582cd49412ae
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
type="menu"option forbuttons, which has wide-reaching consequences for the menu infrastructure.It was intended that
<menu type="context">(originally<menu type="popup">) would be used both for context menus, and for popup menus triggered by buttons. Only the context menu case was ever implemented (in Gecko and, behind a flag, in Blink). As such, removing support for the triggered-by-button case allows us to remove a lot of now-unnecessary abstraction; for example, we can rename the "popup menu state" to the "context menu state" to match thetype="context"content attribute. And we can relocate all of the processing model for constructing menus into the context menu processing model section. Finally, we can clearly state for authors that the<menu>element has two distinct uses: for customizing the context menu, and as a semantic alternative to<ul>for a list of commands.This fixes #237, although we still need to keep an eye on the entire context menu feature since its cross-browser support is on the low side.
Tests: web-platform-tests/wpt#4769