Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: remove incest joke #3193

Merged
merged 4 commits into from Nov 13, 2017
Merged

Editorial: remove incest joke #3193

merged 4 commits into from Nov 13, 2017

Conversation

dauwhe
Copy link
Contributor

@dauwhe dauwhe commented Nov 3, 2017

The note at the end of the adoption agency algorithm section reads:

This algorithm’s name, the "adoption agency algorithm", comes from the way it causes elements to change parents, and is in contrast with other possible algorithms for dealing with misnested content, which included the "incest algorithm", the "secret affair algorithm", and the "Heisenberg algorithm".

It seems wiser to end the note after "change parents." Fixed downstream already.

@miketaylr
Copy link
Member

miketaylr commented Nov 3, 2017

Not to defend what seems like poor taste in an algorithm name, it seems like these refer to actual algorithms used by browsers, rather than just a joke:

https://chat.stackoverflow.com/transcript/17/2011/11/30/22-24

@gsnedders wrote:

The incest algorithm is IE<9 (as well as legacy modes in IE9, esp. quirks), though in IE10 quirks mode doesn't use it; the secret affair algorithm is Opera < 11.60; and the Heisenberg algorithm is Firefox < 4

@dauwhe
Copy link
Contributor Author

dauwhe commented Nov 3, 2017

Not to defend what seems like poor taste in an algorithm name, it seems like these refer to actual algorithms used by browsers, rather than just a joke:

Thanks for researching that! Googling turned up nothing useful. I suppose the question becomes: is documenting the names of algorithms that are no longer used of benefit to the spec, given the language is distasteful?

@gsnedders
Copy link

The naming of the algorithms used by legacy browsers is a joke; the names don't exist outwith of that note. (I don't know if "adoption agency" has any history before HTML5 using it, probably not?)

@gsnedders
Copy link

The "incest" case is shown in, e.g., http://ln.hixie.ch/?count=1&start=1037910467 where d.previousSibling is also d.parentNode.parentNode (and the DOM terminology is where the name comes from).

@annevk
Copy link
Member

annevk commented Nov 4, 2017

Adoption agency algorithm originated in Safari (see also the acknowledgments section), but I think @Hixie came up with all the algorithm names.

As they're mostly of historical relevance, documented in more detail in that blog post, and the reference to them is probably not understood by the majority of people I agree we should simply remove mention of them.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @domenic land. Suggested commit title:

"Editorial: remove alternative HTML parser algorithm names"

@domenic
Copy link
Member

domenic commented Nov 4, 2017

I'd like to retain the history although I agree that the exact names don't seem useful as e.g. they don't turn up good Google results. Instead could we update this PR to make "other possible algorithms" link to the blog post? Then getting rid of the rest of the sentence is fine, and the change becomes a net addition to the spec instead of a removal. WDYT @dauwhe?

@dauwhe
Copy link
Contributor Author

dauwhe commented Nov 6, 2017

Works for me!

@rniwa
Copy link
Collaborator

rniwa commented Nov 6, 2017

I'm not certain retaining old historic algorithms is useful at this point. Major browsers have been shipping the HTML5 parser for 5-6 years by now. What's the use of documenting those historical parser behavior for authors and implementors reading the spec?

If anything, people can look at old copies of the HTML specification to read about? If anything, we can just move this to some note for historical purposes.

@domenic
Copy link
Member

domenic commented Nov 6, 2017

@rniwa we are already discussing the contents of a note that exists for historical purposes.

@domenic
Copy link
Member

domenic commented Nov 6, 2017

@dauwhe did you want to add the link I suggested (when you have time), or shall I? Happy to do so, just let me know.

@dauwhe
Copy link
Contributor Author

dauwhe commented Nov 6, 2017

@dauwhe did you want to add the link I suggested (when you have time), or shall I? Happy to do so, just let me know.

Feel free to add it, given that your infinitely better understanding of the issues will lead to better language. Thanks!

@rniwa
Copy link
Collaborator

rniwa commented Nov 6, 2017

@rniwa we are already discussing the contents of a note that exists for historical purposes.

I meant a separate note document, not a note in the spec itself.

@domenic
Copy link
Member

domenic commented Nov 7, 2017

@annevk mind re-reviewing and/or landing? Commit message suggestion:

Editorial: remove alternative HTML parser algorithm names

Instead, link to a blog post post detailing them and their origins.

source Outdated
with misnested content, which included the "incest algorithm", the "secret affair algorithm", and
the "Heisenberg algorithm".</p>
causes elements to change parents, and is in contrast with <a
href="https://ln.hixie.ch/?start=1037910467&count=1">other possible algorithms</a> for dealing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be &amp; I think.

@annevk annevk merged commit f43716f into whatwg:master Nov 13, 2017
@annevk
Copy link
Member

annevk commented Nov 13, 2017

Thanks again @dauwhe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants