-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust registerProtocolHandler() handling #5524
Adjust registerProtocolHandler() handling #5524
Conversation
source
Outdated
@@ -2503,7 +2503,8 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |||
<li><dfn data-x="concept-url-equals" data-x-href="https://url.spec.whatwg.org/#concept-url-equals">URL equals</dfn></li> | |||
<li><dfn data-x="serialize an integer" data-x-href="https://url.spec.whatwg.org/#serialize-an-integer">serialize an integer</dfn></li> | |||
<li><dfn data-x-href="https://url.spec.whatwg.org/#default-encode-set">Default encode set</dfn></li> | |||
<li><dfn data-x-href="https://url.spec.whatwg.org/#utf-8-percent-encode">UTF-8 percent encode</dfn></li> | |||
<li><dfn data-x-href="https://url.spec.whatwg.org/#external-string-encode-set">External string encode set</dfn></li> | |||
<li><dfn data-x-href="https://url.spec.whatwg.org/#string-utf-8-percent-encode">string UTF-8 percent encode</dfn></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are unavailable yet, probably pending PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, see whatwg/url#503. With that out of the way it would be relatively straightforward to add an external string encode set to URL as described in the last bullet point of #3377 (comment).
How does Chrome do on the tests in web-platform-tests/wpt#23504? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding "do not merge yet" until whatwg/url#503 gets merged.
I'm not sure, I was hoping someone else could check. I keep running into certificate errors for the service worker. |
Complements whatwg/html#5524. Closes #369.
This makes things a bit more explicit and roughly aligns what was "escaped version" with implementations. Corresponding URL Standard PR: whatwg/url#513. Tests: web-platform-tests/wpt#23504. Closes #3377.
403f78e
to
97d67cb
Compare
It's not clear to me that the "Leaking credentials" part is obsolete? There's nothing in the processing model that prevents substituting in credentialed URLs in the |
I restored both for now. They are actually useful to have as we evaluate new schemes to add to the safelist. And also for people minting web+ schemes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but unclear whether we want to wait on tests/clear implementer interest. (I'll get back to the tests PR in a bit.)
Complements whatwg/html#5524. Closes #369.
See #3377 (comment) and #3377 (comment) for Chromium interest and tests. |
I think we're solid on implementation interest and tests now! I'll wait for @annevk to get back from OOO so we can merge whatwg/url#513 and this PR together. |
Complements whatwg/html#5524. Closes #369.
…for percent encoding, a=testonly Automatic update from web-platform-tests registerProtocolHandler(): manual tests for percent encoding For whatwg/html#5524. -- wpt-commits: 084b7c4b34e54882ace03e3247ab60268e18b15d wpt-pr: 23504
…for percent encoding, a=testonly Automatic update from web-platform-tests registerProtocolHandler(): manual tests for percent encoding For whatwg/html#5524. -- wpt-commits: 084b7c4b34e54882ace03e3247ab60268e18b15d wpt-pr: 23504
…for percent encoding, a=testonly Automatic update from web-platform-tests registerProtocolHandler(): manual tests for percent encoding For whatwg/html#5524. -- wpt-commits: 084b7c4b34e54882ace03e3247ab60268e18b15d wpt-pr: 23504 UltraBlame original commit: 0fc4ea2bb5e112c615dc7796455c526ded9342d8
…for percent encoding, a=testonly Automatic update from web-platform-tests registerProtocolHandler(): manual tests for percent encoding For whatwg/html#5524. -- wpt-commits: 084b7c4b34e54882ace03e3247ab60268e18b15d wpt-pr: 23504 UltraBlame original commit: 57aa12b4158d1813056006747e1590b43850b0c8
…for percent encoding, a=testonly Automatic update from web-platform-tests registerProtocolHandler(): manual tests for percent encoding For whatwg/html#5524. -- wpt-commits: 084b7c4b34e54882ace03e3247ab60268e18b15d wpt-pr: 23504 UltraBlame original commit: 0fc4ea2bb5e112c615dc7796455c526ded9342d8
…for percent encoding, a=testonly Automatic update from web-platform-tests registerProtocolHandler(): manual tests for percent encoding For whatwg/html#5524. -- wpt-commits: 084b7c4b34e54882ace03e3247ab60268e18b15d wpt-pr: 23504 UltraBlame original commit: 57aa12b4158d1813056006747e1590b43850b0c8
…for percent encoding, a=testonly Automatic update from web-platform-tests registerProtocolHandler(): manual tests for percent encoding For whatwg/html#5524. -- wpt-commits: 084b7c4b34e54882ace03e3247ab60268e18b15d wpt-pr: 23504 UltraBlame original commit: 0fc4ea2bb5e112c615dc7796455c526ded9342d8
…for percent encoding, a=testonly Automatic update from web-platform-tests registerProtocolHandler(): manual tests for percent encoding For whatwg/html#5524. -- wpt-commits: 084b7c4b34e54882ace03e3247ab60268e18b15d wpt-pr: 23504 UltraBlame original commit: 57aa12b4158d1813056006747e1590b43850b0c8
…for percent encoding, a=testonly Automatic update from web-platform-tests registerProtocolHandler(): manual tests for percent encoding For whatwg/html#5524. -- wpt-commits: 084b7c4b34e54882ace03e3247ab60268e18b15d wpt-pr: 23504
…for percent encoding, a=testonly Automatic update from web-platform-tests registerProtocolHandler(): manual tests for percent encoding For whatwg/html#5524. -- wpt-commits: 084b7c4b34e54882ace03e3247ab60268e18b15d wpt-pr: 23504
This makes things a bit more explicit and aligns what was "escaped version" with implementations.
Corresponding URL Standard PR: whatwg/url#513
Tests: web-platform-tests/wpt#23504
Closes #3377.
(See WHATWG Working Mode: Changes for more details.)
/form-control-infrastructure.html ( diff )
/infrastructure.html ( diff )
/system-state.html ( diff )