Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the component percent-encode set #513

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Add the component percent-encode set #513

merged 1 commit into from
Aug 4, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented May 12, 2020

Complements whatwg/html#5524.

Closes #369.


Preview | Diff

@annevk annevk requested review from mgiuca and domenic May 12, 2020 08:37
annevk added a commit to whatwg/html that referenced this pull request May 12, 2020
This makes things a bit more explicit and roughly aligns what was "escaped version" with implementations.

Corresponding URL Standard PR: whatwg/url#513.

Tests: web-platform-tests/wpt#23504.

Closes #3377.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

url.bs Outdated Show resolved Hide resolved
url.bs Outdated Show resolved Hide resolved
@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label May 12, 2020
@annevk
Copy link
Member Author

annevk commented May 12, 2020

I'll wait with this until we're all certain about whatwg/html#5524.

@annevk
Copy link
Member Author

annevk commented May 13, 2020

Now that bc7ac86 merged I should probably add a note here that the special-query percent-encode set's U+0027 (') is not covered by the component percent-encode set. Apart from that the component percent-encode set is a superset of all others I believe. (Or maybe I should wait even more until I have converted application/x-www-form-urlencoded...)

@annevk
Copy link
Member Author

annevk commented May 14, 2020

Per https://whatpr.org/url/518.html#application-x-www-form-urlencoded-percent-encode-set this component percent-encode set would end up being a subset of the application/x-www-form-urlencoded percent-encode set. That seems fine.

@annevk annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Aug 4, 2020
@annevk annevk merged commit 975614e into master Aug 4, 2020
@annevk annevk deleted the annevk/component branch August 4, 2020 08:59
annevk added a commit to whatwg/html that referenced this pull request Aug 4, 2020
This makes things a bit more explicit and roughly aligns what was "escaped version" with implementations.

Corresponding URL Standard PR: whatwg/url#513.

Tests: web-platform-tests/wpt#23504.

Closes #3377.
mfreed7 pushed a commit to mfreed7/html that referenced this pull request Sep 11, 2020
This makes things a bit more explicit and roughly aligns what was "escaped version" with implementations.

Corresponding URL Standard PR: whatwg/url#513.

Tests: web-platform-tests/wpt#23504.

Closes whatwg#3377.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Need an "unreserved" character set (and better define how to percent-encode arbitrary strings)
2 participants