-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: make note about "in body" insertion mode account for edge case #9780
Editorial: make note about "in body" insertion mode account for edge case #9780
Conversation
3b6d306
to
68e2437
Compare
68e2437
to
6133385
Compare
Can you please sign the participation agreement |
Sure, done :) |
Off-topic, but it seems a little weird that we'd only run when scripting is disabled for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Why is that weird considering that we run it for both text and "any other element" in "in body"? |
Looks like my review wasn't enough for the rules that GitHub enforces. |
I'm not sure, it seemed like something that could be done whether scripting is disabled or enabled. It isn't immediately clear to me that distinction is deliberate, but I also can't recall what the actual difference would be in parsing behavior… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some editorial nits, but thanks for verifying this is correct @hsivonen! And thanks for the fix @not-my-profile!
source
Outdated
<p class="note">This element will be an <span>ordinary</span> element | ||
(with one exception: it can also be a <code>noscript</code> element, | ||
if the <span>scripting flag</span> is disabled).</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make this something like:
This element will be an ordinary element. With one exception: when the scripting flag is disabled it can also be a noscript element.
and then wrap using the 100 column rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :)
(Although I have kept if
rather than when
and also kept the comma in the new sentence.)
This note found in the "Any other start tag" condition of the "in body" insertion mode, previously did not account for a "noscript" start tag being able to reach it, if the scripting flag is disabled (since the only preceding condition that can match a start tag whose tag name is "noscript" has the clause "if the scripting flag is enabled"). ("noscript" is in the special category and thus non-ordinary.)
6133385
to
32dc450
Compare
This note found in the "Any other start tag" condition of the "in body" insertion mode, previously did not account for a "noscript" element being able to reach it, if the scripting flag is disabled (since the only preceding condition that can match a start tag whose tag name is "noscript" has the clause "if the scripting flag is enabled").
("noscript" is in the special category and thus non-ordinary.)
/parsing.html ( diff )