Enabling Subclassing of Reflect.Loader (major reorganization)
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Well-known intrinsics are built-in objects that are explicitly referenced by the algorithms of this specification and which usually have Realm specific identities. Unless otherwise specified each intrinsic object actually corresponds to a set of similar objects, one per Realm. | ||
|
|
||
| Within this specification a reference such as %name% means the intrinsic object, associated with the current Realm, corresponding to the name. Determination of the current Realm and its intrinsics is described in ES2015, 8.3. The well-known intrinsics are listed in Table X. |
There was a problem hiding this comment.
Italicize the "meta-variable" name, as in:
"a reference such as %name% means the intrinsic object, associated with the current Realm, corresponding to name."
(But don't italicize concrete names like %Loader% and %LoaderPrototype%.)
| @@ -899,13 +1030,11 @@ The browser loader has an extra internal slot: | |||
| <li>top-level packages consult \[[Site]]: <code>"jquery"</code>, <code>"ember/data"</code> | |||
There was a problem hiding this comment.
delete this TODO since we're deferring site-packages
caridy
changed the title
Reflect.LoaderReflect.Loader (major reorganization)
This was referenced Aug 21, 2015
Closed
Open
…e dynamic module record, all the methods are just abstract operations.
|
|
||
| <h4 id="create-module-mutator" aoid="CreateModuleMutator">CreateModuleMutator(module)</h4> | ||
| The Reflect.Module constructor is designed to be subclassable. It may be used as the value in an extends clause of a class definition. Subclass constructors that intend to inherit the specified Module behaviour must include a super call to the Reflect.Module constructor to create and initialize the subclass instance with the internal state necessary to support the Reflect.Module.prototype built-in methods. |
There was a problem hiding this comment.
change the end of this to "with the internal state necessary to integrated with loaders."
| <p> | ||
| The site package system serves as a simple coordination mechanism for modest-sized applications, but it does not provide all functionality required of a full-fledged package management system. It is expected that development ecosystems will build around package management tools that deal with requirements outside the scope of this specification, such as version management and allowing multiple versions of a library to coexist with the same name. | ||
| </p> | ||
| <h4 id="Reflect.Module.prototype.constructor">Reflect.Module.prototype.constructor</h4> |
There was a problem hiding this comment.
remove this -- there should not be a constructor property on the prototype (it can't have any properties).
dherman
pushed a commit
that referenced
this pull request
Aug 21, 2015
Enabling Subclassing of `Reflect.Loader` (major reorganization)
|
So much amazing work. Thanks @caridy, this is such great progress. <3 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiled spec from this PR
Changes:
System.loaderis an instance of Browser Loaderfor (let entry of System.loader.registry) {})stateandstatePromiseinstead of exposing all available internal promises for every past state)