Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadableByteStreamControllerPullInto should always transfer the given buffer #752

Closed
tschneidereit opened this issue Jul 21, 2017 · 0 comments
Assignees

Comments

@tschneidereit
Copy link
Contributor

Currently, the buffer is not transferred if the bodies of steps 7 or 8 (sub-steps a or b) are hit.

For step 8, that's maybe not too bad, because the buffer's contents are copied and the buffer itself isn't exposed anyway. For step 7 we do expose the non-transferred buffer as the chunk value's underlying buffer.

In any case, it seems inconsistent for whether the buffer will be transferred or not to depend on the exact results of the pullInto operation.

Is there any reason not to just transfer the buffer before step 5?

cc @tyoshino @domenic

tschneidereit added a commit to tschneidereit/streams that referenced this issue Jul 21, 2017
domenic pushed a commit to tschneidereit/streams that referenced this issue Sep 15, 2017
@domenic domenic self-assigned this Sep 15, 2017
domenic pushed a commit to tschneidereit/streams that referenced this issue Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants