Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference implementation's ReadableStream{Default,BYOB}ReadResult.webidl #1138

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

ninevra
Copy link
Contributor

@ninevra ninevra commented Jun 25, 2021

The spec says this should be {value: any, done: boolean}, not {chunk: any, done: boolean}.

The code generated by this webidl file is never run, because ReadableStreamDefaultReadResults are only ever used wrapped in Promises, which webidl2js currently doesn't unwrap.

The [spec](https://streams.spec.whatwg.org/#default-reader-class-definition) says this should be `{value: any, done: boolean}`, not `{chunk: any, done: boolean}`.

The code generated by this webidl file is never run, because `ReadableStreamDefaultReadResult`s are only ever used wrapped in `Promise`s, which `webidl2js` currently doesn't unwrap.
@MattiasBuelens
Copy link
Collaborator

Good catch! Looks like ReadableStreamBYOBReadResult.webidl is also wrong. Could you fix that one as well? 🙂

@ninevra ninevra changed the title Fix reference implementation's ReadableStreamDefaultReadResult.webidl Fix reference implementation's ReadableStream{Default,BYOB}ReadResult.webidl Jun 25, 2021
@ninevra
Copy link
Contributor Author

ninevra commented Jun 25, 2021

I expected I'd be able to sign the participation agreement in short order, but it's a lot of text (given that it pulls in the entire list of WHATWG policies), and it does contain some things I'm not comfortable with, such as the physical location field, the explicit national security exception in the privacy policy, and the ongoing, dubiously terminable requirement to inform WHATWG of any change in employment. It'd take me at least a few days to read everything carefully and evaluate whether I want to sign, which is kind of silly for such a tiny PR.

Meanwhile if someone else wants to submit their own PR for this issue and close this one they're welcome to do that. Or, if this PR doesn't require signing the participation agreement (since it doesn't touch the standard and couldn't possibly carry any IP risk), then that's great too.

@TimothyGu
Copy link
Member

@ninevra Regarding the change in employment clause, generally it's enough to make a PR yourself to update your affiliation in the participant-data repo, which I have done myself numerous times in the past. Additionally, my belief is that generally updating the participant-data the next time you contribute to one of the WHATWG specs will be enough; there's no need to inform WHATWG if you don't "participate" in the future.

For the "national security exception", FWIW note that most of the data you submit on the participation form is already public on participant-data. So your email and physical location would be the only information subject to that exception.

@ninevra
Copy link
Contributor Author

ninevra commented Jun 30, 2021

Participation agreement is signed.

@ninevra
Copy link
Contributor Author

ninevra commented Jun 30, 2021

For the "national security exception", FWIW note that most of the data you submit on the participation form is already public on participant-data. So your email and physical location would be the only information subject to that exception.

I'm not actually afraid that the WHATWG might decide to release my personal data for reasons of national security. I just think it reflects poorly on WHATWG (as stewards in part of a piece of global information infrastructure that necessarily interacts with, is influenced by, and comes into conflict with all world governments) that WHATWG prioritizes the "national security" of one particular nation & treats the actual identity of that nation as obvious/implicit, and affirmatively announces its intention to support (a particular) state & law enforcement interests.

@domenic
Copy link
Member

domenic commented Jul 1, 2021

Hi @ninevra,

It looks like you signed the participant agreement with the name "ninevra", which I believe is a pseudonym. Per whatwg/sg#93 we need the legal name that you use to sign contracts. Are you able to fix that by sending a pull request to update https://github.com/whatwg/participant-data/blob/main/individuals.json ?

@ninevra
Copy link
Contributor Author

ninevra commented Jul 1, 2021

It's not a pseudonym, actually.

@domenic
Copy link
Member

domenic commented Jul 1, 2021

Ah OK, so that's the (full) name you sign contracts with in the real world?

@ninevra
Copy link
Contributor Author

ninevra commented Jul 1, 2021

I mean, no that's not my full name. (Most people don't sign most contracts in their full name afaik, omitting some name-parts is culturally accepted at least in the US including in legal contexts. Policies around which name-parts to require are highly variable and often serve to prioritize names from a particular cultural context while mangling others.)
I do have more names, which I add when required.
But by preference, yes, that is the name I use irl and the name I sign contracts with.

The rest of my names are mostly googleable, though, so I've no particular privacy objection to adding them here, if it's a sticking point? I just wasn't going to default to that unless required. Which name-parts does WHATWG require? I see that most entries in participant-data list two names, some list more, some list one, some list one + one or more initials...

@domenic
Copy link
Member

domenic commented Jul 1, 2021

We need enough per whatwg/sg#93 (comment) for the purposes of

confirming the real identity of the individual, [without which] we cannot confirm the validity of the contract with WHATWG, and can also not make a determination about whether the participation agreement can be signed as an individual, or needs to be signed by the employer

This is all pretty vague and lawyer-driven, so it's hard to give a clear answer as to what's required. But my job as an editor is to do basic due diligence before verifying. It would be easier for me to do so if you included given name and family name. Otherwise I'd feel a bit uncomfortable verifying straightaway, and would need to consult with the SG to ensure they have no concerns before proceeding.

It sucks that this is required for small contributions. Unfortunately we don't have a process for distinguishing between small contributions (which are unlikely impact patent and copyright issues) and bigger ones (for which all this machinery serves a real purpose). That's roughly whatwg/sg#63 .

@ninevra
Copy link
Contributor Author

ninevra commented Jul 6, 2021

PR submitted: whatwg/participant-data#38.

domenic pushed a commit to whatwg/participant-data that referenced this pull request Jul 7, 2021
@domenic domenic merged commit 4012d16 into whatwg:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants