Remove _errored and _storedError from TransformStream #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These slots are mostly redundant with the same state on the readable side, so use the ReadableStream [[state]] and [[storedError]] instead to reduce complexity. It is possible for the readable to be "closed" where previously _errored was set, but this doesn't make any practical difference as the implementation threw a TypeError in both cases anyway. TransformStreamError is renamed to TransformStreamDefaultControllerError to better reflect its new semantics. Closes whatwg#796.
domenic
reviewed
Sep 22, 2017
| throw new TypeError('TransformStream is not in a state that can be errored'); | ||
| } | ||
|
|
||
| TransformStreamDefaultControllerError(this, reason); |
There was a problem hiding this comment.
Since TransformStreamDefaultControllerError is so short, can we just inline it here?
There was a problem hiding this comment.
I was thinking it might be useful as a hook for other standards, but since they are more likely to just throw from transform(), maybe not?
There was a problem hiding this comment.
Oh, I see, in parallel to the ones for other controllers. Yeah, maybe keep it, in which case LGTM for the whole patch.
| } | ||
| } | ||
|
|
||
| // This is a no-op if both sides are already errored. | ||
| function TransformStreamErrorInternal(transformStream, e) { |
There was a problem hiding this comment.
This should probably lose the -Internal suffix now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These slots are mostly redundant with the same state on the readable
side, so use the ReadableStream [[state]] and [[storedError]] instead to
reduce complexity.
It is possible for the readable to be "closed" where previously _errored
was set, but this doesn't make any practical difference as the
implementation threw a TypeError in both cases anyway.
TransformStreamError is renamed to TransformStreamDefaultControllerError to
better reflect its new semantics.
Closes #796.