Change the default highWaterMark for readableStrategy to 0 #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reduces "buffer bloat" in pipes. The most significant change is that now be default transform() is called until something is read. In normal use, TransformStream will be used in a pipe and a transform() will be triggered immediately to fill the queue in the following writable. So the difference from the point of view of everyday use is minimal. If the highWaterMark passed to the TransformStream constructor is undefined (or not present) it will be changed to zero before passing it on to the ReadableStream constructor. Some tests assumed that transform() would be called without anything being read and so have been fixed. In most cases the tests were fixed by supplying an explicit highWaterMark to the constructor. Verify that default strategies have the expected values. Closes whatwg#777.
The test "abort should set the close reason for the writable when it happens before cancel during underlying sink write, but cancel should still succeed" was setting the highWaterMark for the writable when it should have been setting it for the readable. Fix it.
ES6 defaulting syntax can do it directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reduces "buffer bloat" in pipes. The most significant change is that
now be default transform() is called until something is read. In normal
use, TransformStream will be used in a pipe and a transform() will be
triggered immediately to fill the queue in the following writable. So the
difference from the point of view of everyday use is minimal.
If the highWaterMark passed to the TransformStream constructor is
undefined (or not present) it will be changed to zero before passing it
on to the ReadableStream constructor.
Some tests assumed that transform() would be called without anything
being read and so have been fixed. In most cases the tests were fixed by
supplying an explicit highWaterMark to the constructor.
Verify that default strategies have the expected values.
Closes #777.