Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give pipeTo more latitude about byob chunk sizes #989

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

ricea
Copy link
Collaborator

@ricea ricea commented Feb 18, 2019

If pipeTo() uses a BYOB reader, it is required to use
WritableStreamDefaultWriterGetDesiredSize(writer) to determine chunk
sizes. However, if, for example, the HWM is too low, the resulting value
may be an unsuitable chunk size. Relax the language to give
implementations latitude to use other information to choose an
appropriate chunk size.

Closes #938.


Preview | Diff

If pipeTo() uses a BYOB reader, it is required to use
WritableStreamDefaultWriterGetDesiredSize(writer) to determine chunk
sizes. However, if, for example, the HWM is too low, the resulting value
may be an unsuitable chunk size. Relax the language to give
implementations latitude to use other information to choose an
appropriate chunk size.

Closes whatwg#938.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

@domenic domenic merged commit 8be75dd into whatwg:master Feb 21, 2019
@domenic domenic added the piping label Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants