Return null origin of "blob:" URL containing inner non-"http(s):" URL #771

rmisev · 2023-05-22T19:59:07Z

Fixes: #770.

At least two implementers are interested (and none opposed):
- Chromium
- Gecko
- WebKit
Tests are written and can be reviewed and commented upon at:
- URL: origin of "blob:" URL containing inner non-"http(s):" URL web-platform-tests/wpt#40133
Implementation bugs are filed:
MDN issue is filed: N/A

(See WHATWG Working Mode: Changes for more details.)

url.bs

annevk

This looks good to me. For a moment I thought we could use "HTTP(S) scheme" but that's not defined here and that's probably fine.

url.bs

annevk · 2023-05-23T16:04:59Z

@ricea @zcorpan thoughts?

ricea

This change looks good to me. Since it is already shipping in Chromium, I'm not too worried about compatibility.

zcorpan · 2023-05-24T07:34:15Z

This seems OK to me. cc @valenting

valenting · 2023-05-24T07:54:01Z

This makes sense to me. I filed Bug 1834703 - Return null origin of "blob:" URL containing inner "blob:" URL for Firefox changes. Thank you for the tests.

annevk · 2023-05-24T09:35:23Z

@ricea to be clear, all browsers have failures here. E.g., "Origin parsing: blob:file://host/path without base" yields !EQ("null", "file://") in Chromium. (Same for ftp, ws, and wss.)

@rmisev do you want to file the remaining implementation bugs?

ricea · 2023-05-24T10:25:13Z

@ricea to be clear, all browsers have failures here. E.g., "Origin parsing: blob:file://host/path without base" yields !EQ("null", "file://") in Chromium. (Same for ftp, ws, and wss.)

I am okay with that.

rmisev · 2023-05-24T15:05:25Z

@rmisev do you want to file the remaining implementation bugs?

@annevk, I think you would fill in the bug reports faster than me.

Tests for whatwg/url#771.

…"http(s):" URL r=smaug,valentin Return null origin of a blob URL containing an inner URL which is not of http/https schemes to comply with new spec change. Examples: - "blob:blob:https://example.org/" - inner blob URL - "blob:ws://example.org/" - inner non-http(s) URL Spec PR: whatwg/url#771 WPT tests: web-platform-tests/wpt#40133 New WPT tests are not merged into central yet, so tested manually instead and results are as expected with WPTs. Differential Revision: https://phabricator.services.mozilla.com/D179400

…"http(s):" URL r=smaug,valentin Return null origin of a blob URL containing an inner URL which is not of http/https schemes to comply with new spec change. Examples: - "blob:blob:https://example.org/" - inner blob URL - "blob:ws://example.org/" - inner non-http(s) URL Spec PR: whatwg/url#771 WPT tests: web-platform-tests/wpt#40133 New WPT tests are not merged into central yet, so tested manually instead and results are as expected with WPTs. Differential Revision: https://phabricator.services.mozilla.com/D179400 UltraBlame original commit: 34c5add98599ea6a4896ef1c424ef3120531ba00

… inner schemes r=smaug,valentin Return null origin of a blob URL containing an inner URL which is not of some schemes (https, http, file per spec) to comply with new spec changes. Allowed schemes also include moz-extension for our own purposes. Examples: - "blob:blob:https://example.org/" - inner blob URL - "blob:ws://example.org/" - inner non-http(s) URL Spec PR: whatwg/url#771 WPT tests: web-platform-tests/wpt#40133 New WPT tests are not merged into central yet, so tested manually instead and results are as expected with WPTs. Differential Revision: https://phabricator.services.mozilla.com/D179400

… inner schemes r=smaug,valentin Return null origin of a blob URL containing an inner URL which is not of some schemes (https, http, file per spec) to comply with new spec changes. Allowed schemes also include moz-extension for our own purposes. Examples: - "blob:blob:https://example.org/" - inner blob URL - "blob:ws://example.org/" - inner non-http(s) URL Spec PR: whatwg/url#771 WPT tests: web-platform-tests/wpt#40133 New WPT tests are not merged into central yet, so tested manually instead and results are as expected with WPTs. Differential Revision: https://phabricator.services.mozilla.com/D179400 UltraBlame original commit: 7cd945c5be6eac2287abb63f113bdc2ad17930a6

… inner schemes r=smaug,valentin Return null origin of a blob URL containing an inner URL which is not of some schemes (https, http, file per spec) to comply with new spec changes. Allowed schemes also include moz-extension for our own purposes. Examples: - "blob:blob:https://example.org/" - inner blob URL - "blob:ws://example.org/" - inner non-http(s) URL Spec PR: whatwg/url#771 WPT tests: web-platform-tests/wpt#40133 New WPT tests are not merged into central yet, so tested manually instead and results are as expected with WPTs. Differential Revision: https://phabricator.services.mozilla.com/D179400

…ner non-"http(s):" URL, a=testonly Automatic update from web-platform-tests URL: origin of "blob:" URL containing inner non-"http(s):" URL Tests for whatwg/url#771. -- wpt-commits: fbd7ee145c0bd0158ae30f3a2fbf3c54263da19e wpt-pr: 40133

… inner schemes r=smaug,valentin Return null origin of a blob URL containing an inner URL which is not of some schemes (https, http, file per spec) to comply with new spec changes. Allowed schemes also include moz-extension for our own purposes. Examples: - "blob:blob:https://example.org/" - inner blob URL - "blob:ws://example.org/" - inner non-http(s) URL Spec PR: whatwg/url#771 WPT tests: web-platform-tests/wpt#40133 New WPT tests are not merged into central yet, so tested manually instead and results are as expected with WPTs. Differential Revision: https://phabricator.services.mozilla.com/D179400 UltraBlame original commit: af0665af954105365927736b6a65c4d28533bc4d

…ner non-"http(s):" URL, a=testonly Automatic update from web-platform-tests URL: origin of "blob:" URL containing inner non-"http(s):" URL Tests for whatwg/url#771. -- wpt-commits: fbd7ee145c0bd0158ae30f3a2fbf3c54263da19e wpt-pr: 40133 UltraBlame original commit: 6c15bd706256e597096ab747a1b24bc6a2798cbf

… inner schemes r=smaug,valentin Return null origin of a blob URL containing an inner URL which is not of some schemes (https, http, file per spec) to comply with new spec changes. Allowed schemes also include moz-extension for our own purposes. Examples: - "blob:blob:https://example.org/" - inner blob URL - "blob:ws://example.org/" - inner non-http(s) URL Spec PR: whatwg/url#771 WPT tests: web-platform-tests/wpt#40133 New WPT tests are not merged into central yet, so tested manually instead and results are as expected with WPTs. Differential Revision: https://phabricator.services.mozilla.com/D179400 UltraBlame original commit: af0665af954105365927736b6a65c4d28533bc4d

…ner non-"http(s):" URL, a=testonly Automatic update from web-platform-tests URL: origin of "blob:" URL containing inner non-"http(s):" URL Tests for whatwg/url#771. -- wpt-commits: fbd7ee145c0bd0158ae30f3a2fbf3c54263da19e wpt-pr: 40133 UltraBlame original commit: 6c15bd706256e597096ab747a1b24bc6a2798cbf

… inner schemes r=smaug,valentin Return null origin of a blob URL containing an inner URL which is not of some schemes (https, http, file per spec) to comply with new spec changes. Allowed schemes also include moz-extension for our own purposes. Examples: - "blob:blob:https://example.org/" - inner blob URL - "blob:ws://example.org/" - inner non-http(s) URL Spec PR: whatwg/url#771 WPT tests: web-platform-tests/wpt#40133 New WPT tests are not merged into central yet, so tested manually instead and results are as expected with WPTs. Differential Revision: https://phabricator.services.mozilla.com/D179400 UltraBlame original commit: af0665af954105365927736b6a65c4d28533bc4d

…ner non-"http(s):" URL, a=testonly Automatic update from web-platform-tests URL: origin of "blob:" URL containing inner non-"http(s):" URL Tests for whatwg/url#771. -- wpt-commits: fbd7ee145c0bd0158ae30f3a2fbf3c54263da19e wpt-pr: 40133 UltraBlame original commit: 6c15bd706256e597096ab747a1b24bc6a2798cbf

… inner schemes r=smaug,valentin Return null origin of a blob URL containing an inner URL which is not of some schemes (https, http, file per spec) to comply with new spec changes. Allowed schemes also include moz-extension for our own purposes. Examples: - "blob:blob:https://example.org/" - inner blob URL - "blob:ws://example.org/" - inner non-http(s) URL Spec PR: whatwg/url#771 WPT tests: web-platform-tests/wpt#40133 16 WPT subtests newly pass 🎉 Differential Revision: https://phabricator.services.mozilla.com/D179400

rmisev added a commit to rmisev/web-platform-tests that referenced this pull request May 22, 2023

URL: origin of "blob:" containing inner "blob:"

76deb46

Tests for whatwg/url#771

rmisev mentioned this pull request May 22, 2023

URL: origin of "blob:" URL containing inner non-"http(s):" URL web-platform-tests/wpt#40133

Merged

annevk reviewed May 23, 2023

View reviewed changes

url.bs Outdated Show resolved Hide resolved

rmisev force-pushed the blob-origin branch from 18e6f2d to dcc83ac Compare May 23, 2023 15:44

Return null origin of "blob:" URL containing inner non-"http(s):" URL

2782e9f

rmisev force-pushed the blob-origin branch from dcc83ac to 2782e9f Compare May 23, 2023 16:04

annevk approved these changes May 23, 2023

View reviewed changes

url.bs Outdated Show resolved Hide resolved

ricea approved these changes May 24, 2023

View reviewed changes

rmisev changed the title ~~Return null origin of "blob:" URL containing inner "blob:" URL~~ Return null origin of "blob:" URL containing inner non-"http(s):" URL May 24, 2023

annevk pushed a commit to web-platform-tests/wpt that referenced this pull request May 24, 2023

URL: origin of "blob:" URL containing inner non-"http(s):" URL

fbd7ee1

Tests for whatwg/url#771.

annevk merged commit eee49fd into whatwg:main May 24, 2023

This was referenced May 24, 2023

Return opaque origin for blob: URL containing inner non-http(s): URL denoland/deno#19241

Closed

Return opaque origin for blob: URL containing inner non-http(s): URL nodejs/node#48157

Closed

rmisev deleted the blob-origin branch May 25, 2023 06:37

CanadaHonk mentioned this pull request May 30, 2023

Add file as allowed scheme for blob origin #775

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return null origin of "blob:" URL containing inner non-"http(s):" URL #771

Return null origin of "blob:" URL containing inner non-"http(s):" URL #771

rmisev commented May 22, 2023 •

edited by annevk

Loading

annevk left a comment

annevk commented May 23, 2023

ricea left a comment

zcorpan commented May 24, 2023

valenting commented May 24, 2023

annevk commented May 24, 2023 •

edited

Loading

ricea commented May 24, 2023

rmisev commented May 24, 2023

Return null origin of "blob:" URL containing inner non-"http(s):" URL #771

Return null origin of "blob:" URL containing inner non-"http(s):" URL #771

Conversation

rmisev commented May 22, 2023 • edited by annevk Loading

annevk left a comment

Choose a reason for hiding this comment

annevk commented May 23, 2023

ricea left a comment

Choose a reason for hiding this comment

zcorpan commented May 24, 2023

valenting commented May 24, 2023

annevk commented May 24, 2023 • edited Loading

ricea commented May 24, 2023

rmisev commented May 24, 2023

rmisev commented May 22, 2023 •

edited by annevk

Loading

annevk commented May 24, 2023 •

edited

Loading