Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should callback interfaces with more than one operation be supported? #661

Closed
Ms2ger opened this issue Feb 26, 2019 · 4 comments
Closed

Comments

@Ms2ger
Copy link
Member

Ms2ger commented Feb 26, 2019

Looking at Gecko, there's EventListener, NodeFilter and XPathNSResolver, all with one operation; ObserverCallback, also with one operation, but shouldn't even exist (https://bugzilla.mozilla.org/show_bug.cgi?id=1530702); and MozIdleObserver, which isn't exposed to script. WebKit doesn't seem to have any others either.

There's already a note that suggests using dictionaries instead of callback interfaces, so I think we should bite the bullet and mark the entire thing as legacy, and reduce the spec to only support what's actually used.

@annevk
Copy link
Member

annevk commented Feb 26, 2019

See also #100 for some additional context.

@Ms2ger
Copy link
Member Author

Ms2ger commented Mar 4, 2019

We should probably also remove support for attributes, and the "get a user object's attribute value" and "set a user object's attribute value" algorithms.

@domenic
Copy link
Member

domenic commented Mar 4, 2019

the "get a user object's attribute value" and "set a user object's attribute value" algorithms.

Those are generally useful, not just for callback interfaces. Although perhaps people aren't using them, instead preferring to declare dictionary types and convert, or use ES's Get() directly, or similar.

@Ms2ger
Copy link
Member Author

Ms2ger commented Mar 4, 2019

The algorithms explicitly only work "given a callback interface type value object", so at the very least, we'd need to clarify that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants