Bump latest Ruby versions #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Dec 25, 2017
lib/parser/current.rb
Outdated
| @@ -46,7 +46,7 @@ def warn_syntax_deviation(feature, version) | |||
| CurrentRuby = Ruby23 | |||
|
|
|||
| when /^2\.4\./ | |||
| current_version = '2.4.0' | |||
| current_version = '2.4.3' | |||
There was a problem hiding this comment.
Nope, we still don't even support 2.4.1. If you remove this change I'll merge the rest.
There was a problem hiding this comment.
Interesting, thanks!
whitequark
approved these changes
Dec 25, 2017
|
Thanks! Would you mind releasing a new version? |
|
@whitequark Do you have a release planned including these changes? |
|
When I have time for it, yes. |
rspeicher
pushed a commit
to gitlabhq/gitlabhq
that referenced
this pull request
Mar 14, 2018
These warnings would show when running rspec: ``` warning: parser/current is loading parser/ruby23, which recognizes warning: 2.3.5-compliant syntax, but you are running 2.3.6. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. ``` Related PRs: * whitequark/parser#422 * mbj/unparser#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.ruby-lang.org/en/downloads/releases/