Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ Ruby 3.3 support #904

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Conversation

olefriis
Copy link
Contributor

@olefriis olefriis commented Jan 5, 2023

I've basically mimicked #841.

  • Copied lib/parser/ruby32.y to lib/parser/ruby33.y, editing the version number on the first line. Since Ruby 3.2 was released a couple of weeks ago, the grammars are probably identical for now (?).
  • Other changes similar to + ruby32.y: branch parser #841.
  • Added a changelog entry. As I understand the version number specs for this repo, adding Ruby 3.3 support means bumping a "minor" version. I have not bumped the version in lib/parser/version.rb, as I suppose this will be part of the actual release process. Also, since I do not know when the version will be released, I haven't added a timestamp in the changelog.

Copy link
Collaborator

@iliabylich iliabylich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've left a few comments.

Also there are two missing pieces:

  1. parse_helper.rb, ALL_VERSIONS constants should include 3.3
  2. parse_helper.rb, parser_for_ruby_version method needs to handle 3.3

CHANGELOG.md Outdated Show resolved Hide resolved
lib/parser/current.rb Outdated Show resolved Hide resolved
lib/parser/ruby33.y Outdated Show resolved Hide resolved
@olefriis
Copy link
Contributor Author

olefriis commented Jan 5, 2023

Thanks for the extremely quick feedback, @iliabylich. I've applied the suggested changes, except the one about the parser_for_ruby_version needing to handle 3.3. That should already be there, right?

@iliabylich iliabylich merged commit 160dc2e into whitequark:master Jan 5, 2023
@iliabylich
Copy link
Collaborator

Thanks!

@olefriis olefriis deleted the add-ruby-3-3-support branch January 5, 2023 10:18
@nickborromeo
Copy link

👋 @iliabylich can I ask when this change is going to be scheduled to be released as a patch version for the gem? 🙇

@iliabylich
Copy link
Collaborator

I don't plan to release until Ruby 3.2.1 (i.e. with release of the next Ruby version) or in case of a bugfix (that would be parser 3.2.0.1).

Why do you need this change?

@nickborromeo
Copy link

nickborromeo commented Jan 12, 2023

We have a running branch every week to test Ruby and the sha that we are targeting is 9726736006b3f74635fd8af05814fe0908e2cf84 which contains this change for the versions

It looks like there are other gems like rubocop-ast and rubocop that rely on this, right now we are just trying to get a timeline of things; which you have already provided since you are planning to release when Ruby 3.2.1 comes out.

koic added a commit to koic/rubocop-ast that referenced this pull request Feb 10, 2023
Parser gem has been started development for Ruby 3.3 (edge Ruby).
whitequark/parser#904

And this PR update to require Parser 3.2.1.0 or higher, which contains `Parser::Ruby33`.
https://github.com/whitequark/parser/blob/master/CHANGELOG.md#v3210-2023-02-09
bbatsov pushed a commit to rubocop/rubocop-ast that referenced this pull request Feb 10, 2023
Parser gem has been started development for Ruby 3.3 (edge Ruby).
whitequark/parser#904

And this PR update to require Parser 3.2.1.0 or higher, which contains `Parser::Ruby33`.
https://github.com/whitequark/parser/blob/master/CHANGELOG.md#v3210-2023-02-09
@koic koic mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants