Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emacs variable line-move-visual feature implement #1761

Merged

Conversation

DrScKAWAMOTO
Copy link
Contributor

Hi.

I had implemented Emacs variable line-move-visual feature.
This feature affects NextLine, PreviousLine, ScrollUpCommand, and ScrollDownCommand classes.
If lineMoveVisual setting is set to true, then these classes act compatible with whitphx/vscode-emacs-mcx.
If lineMoveVisual settting is set to false, then these classes act as if logical lines.
So we can use emacs keyboard macro precisely, which is implemented by Keyboard Macro Beta extension (https://github.com/tshino/vscode-kb-macro) and Awesome Emacs Keymap wrapper
(https://github.com/tshino/vscode-kb-macro/blob/main/keymap-wrapper/tuttieee.emacs-mcx.json).
The default lineMoveVisual setting is true.

Thanx.

Copy link
Owner

@whitphx whitphx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution.

@whitphx whitphx merged commit 8d679ed into whitphx:main Nov 12, 2023
6 checks passed
@DrScKAWAMOTO DrScKAWAMOTO deleted the dev/DrScKAWAMOTO/line-move-visual_feature branch November 12, 2023 12:44
@DrScKAWAMOTO
Copy link
Contributor Author

Thank you for accepting my contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants