Fix 102063901

[pathmapper]

Fixes whosonfirst-data/whosonfirst-data#1697

Updated some properties, most of them related to statoids (http://www.statoids.com/yde.html).

Also updated with the correct geometry from de-bkg.

Validated with wof-validate-properties and wof-validate-geometry.

To Do:

• geom:area
• geom:area_square_m
• geom:latitude
• geom:longitude
• update alt geometry

https://whosonfirst.org/docs/properties/geom/ states that these properties are derived from Shapely.
Is it a must to use Shapely or is it ok to calculate these properties also e.g. with QGIS?
If Shapely should be used, is there a script somewhere for this task?
What is the unit of geom:area?

[missinglink]

I think the 'exportify' tool can help setting those properties.

[pathmapper]

Thanks @missinglink, used the tool in 9e68f92

The centroid coordinates ( geom:latitude and geom:longitude) and geom:area were updated.

geom:area_square_m still needs an update and I still wonder which unit is used for geom:area, since this value is now 0.279932.

[pathmapper]

Quattroshapes download links are down, at least since January 2018, so remove the alt geometry and related properties?

[pathmapper]

Hmm, there is another id, which has the correct geometry but also some Oldenburg data:
https://spelunker.whosonfirst.org/id/102063947/

Seems like "Kreisfreie Stadt Osnabrück" and "Landkreis Osnabrück" have some properties swapped with each other and also mixed with some Oldenburg data. The questions is which id should belong to which one:
Landkreis Osnabrück -> 102063901
Kreisfreie Stadt Osnabrück -> 102063947
or vice versa?

[missinglink]

Regarding 'area', it's not clear what unit it is..

I can see from the code that python is calling the shapely library but shapely docs don't specify.

• https://github.com/whosonfirst/py-mapzen-whosonfirst-export/blob/master/mapzen/whosonfirst/export/__init__.py#L302
• https://shapely.readthedocs.io/en/stable/manual.html#object.area

[stepps00]

Thanks for the issue and PR, @pathmapper.

Is it a must to use Shapely or is it ok to calculate these properties also e.g. with QGIS? If Shapely should be used, is there a script somewhere for this task?

As @missinglink pointed out, the Exportify tool should set the geom:* properties for you.

What is the unit of geom:area?

Shapely uses the Cartesian system, the units you see should be in meters/square meters. (geom:area_square_m)

Overall, I agree with the statoids/population/name changes, they all look great. I'm having issues with viewing the geometry diff, though, so I'll need to check the changes out in QGIS. We recently refactored many of the geometries in Germany as part of #1 and have contiguous coverage at most placetypes... I'll poke around with these changes and follow up with any notes.

Thanks!

[pathmapper]

shapely docs don't specify

Found this post: https://gis.stackexchange.com/a/166682/105333

Whichever units are represented by the coordinates in your geometries.
Shapely geometries are Cartesian and make no assumptions about being Lon/Lat or anything else.

Shapely docs: https://shapely.readthedocs.io/en/stable/manual.html#coordinate-systems

So there is no unit in our case. Wonder why the geom:area property exists for WOF data ...

[pathmapper]

@stepps00 thanks for your feedback.

Exportify tool should set the geom:* properties for you

There is a property geom:area_square_m, which wasn't set by the Exportify tool. Could be also related to the docker version of the tool which I used.

the units you see should be in meters/square meters.

The exportify tool calculated 0.279932 for geom:area, so I doubt these are square meters. Also there is a seperate property geom:area_square_m. Possible explanation in my #13 (comment) above.

Regarding the geometries:

https://spelunker.whosonfirst.org/id/102063947/ and
https://spelunker.whosonfirst.org/id/102063901/ (modified in this PR)
are complementary. We could also leave the geometries for both IDs as they are and fix the properties (which would mean also to swap the label properties eng_x_preferred_longname and deu_x_preferred_longname).

[pathmapper]

The geom:area_square_m issue is related to the docker tool, submitted whosonfirst/docker-whosonfirst-exportify#5 to fix this.

[pathmapper]

Fresh PR in #17