Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOTICE File with License Information for Dual MIT/Apache-2.0 Compliance #2

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

nnabeyang
Copy link
Contributor

The bluesky-social/atproto repository is dual-licensed under MIT and Apache-2.0 licenses. Therefore, it is necessary to include copies of the licenses in the distributed artifacts. However, the repository currently lacks these copies. This PR addresses this issue by creating a NOTICE file and including the license information within it.

@K-Nksm K-Nksm self-requested a review June 18, 2024 13:11
Copy link
Collaborator

@K-Nksm K-Nksm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

I have additional two questions:

  • Could you provide me an example repository link which just includes NOTICE file to comply MIT license? MIT license seems to require including license term in the source code.
  • Original source code is licensed under dual MIT/Apache-2.0 license. Should I comply to both of these, not one of them?

I would appreciate it if you could just provide a reference url!


In LICENSE.txt in Bluesky repository,

Downstream projects and end users may chose either license individually, or both together, at their discretion.

So we can just use MIT license, which basically requires the users that

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

1

The permission notice can be just the URL to MIT license text2.
The copied files are JSON so I added description keys to include both copyright notice and URL to MIT license text.

From what I googled, NOTICE file is used to comply to Apache-2.0 license3.

Footnotes

  1. https://github.com/bluesky-social/atproto/blob/80dae835405a71a325953858d0966352161e8d80/LICENSE-MIT.txt#L10C1-L11C48

  2. https://qiita.com/takobuta_dev/items/120e710ab99721e98f8d#mit%E3%83%A9%E3%82%A4%E3%82%BB%E3%83%B3%E3%82%B9%E3%81%AE%E5%85%A8%E6%96%87

  3. https://yamory.io/blog/about-apache-license

@K-Nksm K-Nksm merged commit 834b085 into whtwnd:main Jun 18, 2024
@nnabeyang nnabeyang deleted the add-notice-file branch June 18, 2024 13:59
@nnabeyang
Copy link
Contributor Author

@K-Nksm

I believe I misunderstood the handling of dual licensing. Since it is possible to choose either license, I think it is permissible to remove the Apache 2.0 license notation from the NOTICE file. I didn't fully understand because I had never created any deliverables that depended on dual licensing.

Below is a link to a part of the VScode NOTICE file, which serves as an example of dual licensing.
https://github.com/microsoft/vscode/blob/main/ThirdPartyNotices.txt#L2064-L2067

@K-Nksm
Copy link
Collaborator

K-Nksm commented Jun 18, 2024

From the repository you provided, it seems enough to just mention the author and license terms in a file (ThirdPartyNotices in their case, NOTICE in our case) to comply with MIT license.
Therefore this PR properly addresses the license issue.
Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants