Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder size indicator show "k" when over 1,000 #757

Closed
whyboris opened this issue May 16, 2022 · 4 comments
Closed

Folder size indicator show "k" when over 1,000 #757

whyboris opened this issue May 16, 2022 · 4 comments
Labels
good first issue Good for newcomers hacktoberfest hacktoberfest-accepted hacktoberfest

Comments

@whyboris
Copy link
Owner

During "folder view"

When there are more than 999 files in a folder, maybe show 1k, 2k etc - otherwise the number spills over the folder icon 😅
@whyboris whyboris added the good first issue Good for newcomers label May 31, 2022
@heisid heisid mentioned this issue Aug 26, 2022
Closed
@jmdagenais
Copy link
Contributor

Can I work on this issue?

@whyboris
Copy link
Owner Author

Hey @jmdagenais - thank you for the offer of help 😊

Please let me know if you have any trouble while working on this -- I'll be happy to advise on anything 🤝

jmdagenais pushed a commit to jmdagenais/Video-Hub-App that referenced this issue Oct 1, 2022
fix issue whyboris#757 - Folder size indicator show "k" when over 1,000
7c9aa35
@whyboris whyboris mentioned this issue Oct 4, 2022
Merged
@whyboris
Copy link
Owner Author

whyboris commented Oct 4, 2022

Thank you @jmdagenais for the hacktoberfest submission 🎉 - #769 🤝

whyboris pushed a commit that referenced this issue Oct 31, 2022
@jmdagenais
fix issue #757 - Folder size indicator show "k" when over 1,000 (#769)
b56b6c0 
* fix issue #757 - Folder size indicator show "k" when over 1,000

* reduce complexity to respect codeclimate

* issue 757: create a pipe

Co-authored-by: Jean-Michel Dagenais <jm@obkio.com>
@whyboris
Copy link
Owner Author

whyboris commented Nov 1, 2022

Closed with #760 and #769 🤝

@whyboris whyboris closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest hacktoberfest-accepted hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmdagenais @whyboris