Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update example notebooks #286

Merged
merged 6 commits into from
Aug 23, 2021
Merged

Fix and update example notebooks #286

merged 6 commits into from
Aug 23, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Aug 21, 2021

Description

Fix and update s3 example

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@lalmei lalmei added bug Something isn't working documentation Improvements or additions to documentation labels Aug 21, 2021
@lalmei lalmei requested a review from andyndang August 21, 2021 19:02
@coveralls
Copy link

coveralls commented Aug 21, 2021

Pull Request Test Coverage Report for Build 1154516897

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.533%

Totals Coverage Status
Change from base Build 1148890060: 0.0%
Covered Lines: 3620
Relevant Lines: 4281

💛 - Coveralls

@lalmei lalmei enabled auto-merge (rebase) August 21, 2021 19:27
@lalmei lalmei changed the title updated s3 example Fix and update example notebooks Aug 21, 2021
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalmei lalmei merged commit 8c61613 into mainline Aug 23, 2021
@lalmei lalmei deleted the fix_s3_example branch August 23, 2021 15:43
@coveralls
Copy link

coveralls commented Oct 5, 2024

Pull Request Test Coverage Report for Build 1154374887

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 81.479%

Totals Coverage Status
Change from base Build 1148890060: -0.05%
Covered Lines: 3620
Relevant Lines: 4281

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants