-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure notebook test run in correct poetry kernel #287
Conversation
3cbfb17
to
ceaddf5
Compare
Pull Request Test Coverage Report for Build 1159536685Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
update test for faster performance fix notebook for tests style fixes compile protobuf files for test fix workflow remove example paths fix session variable make sure estimate segments doesn't write if there isnt a writer notebook fixes output json fixed
54b4552
to
4a09a11
Compare
@@ -49,5 +52,5 @@ def test_all_notebooks(remove_fail_test=True): | |||
return | |||
|
|||
|
|||
if __name__ == "__main__": | |||
test_all_notebooks() | |||
# if __name__ == "__main__": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor comment
Description
Needs #286 to be merged first, i.e. Review #286 first
General Checklist
if it was a bug, test must cover it.