Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure notebook test run in correct poetry kernel #287

Merged
merged 8 commits into from
Aug 23, 2021

Conversation

lalmei
Copy link
Contributor

@lalmei lalmei commented Aug 22, 2021

Description

  • Made sure notebook test were running in poetry kernel
  • Fix broken tests
  • Removed redudant sub folder notebooks in examples
  • Removed deprecated notebook calling "whylabs" library

Needs #286 to be merged first, i.e. Review #286 first

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@lalmei lalmei added bug Something isn't working documentation Improvements or additions to documentation labels Aug 22, 2021
@lalmei lalmei enabled auto-merge (rebase) August 22, 2021 22:04
@lalmei lalmei force-pushed the notebook_tests_fix branch 3 times, most recently from 3cbfb17 to ceaddf5 Compare August 23, 2021 16:28
@coveralls
Copy link

coveralls commented Aug 23, 2021

Pull Request Test Coverage Report for Build 1160243915

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 81.525%

Totals Coverage Status
Change from base Build 1159298377: -0.008%
Covered Lines: 3621
Relevant Lines: 4282

💛 - Coveralls

update test for faster performance

fix notebook for tests

style fixes

compile protobuf files for test

fix workflow

remove example paths

fix session variable

make sure estimate segments doesn't write if there isnt a writer

notebook fixes

output json fixed
@@ -49,5 +52,5 @@ def test_all_notebooks(remove_fail_test=True):
return


if __name__ == "__main__":
test_all_notebooks()
# if __name__ == "__main__":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove code?

@lalmei lalmei merged commit 11e5a98 into mainline Aug 23, 2021
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment

@lalmei lalmei deleted the notebook_tests_fix branch August 23, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants