Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate solara into a meta package and subpackages #585

Conversation

maartenbreddels
Copy link
Contributor

@maartenbreddels maartenbreddels commented Apr 5, 2024

Install solara-ui without solara-server to reduce dependencies, which is useful for notebook or voila-only usage.

Notebook users can do:

pip install solara-ui

While we still have pip install solara for backward compatibility and first time users, which is equivalent to:

pip install "solara-ui[all]" "solara-server[starlette,dev]"

For production use, we imagine the following would be used:

pip install solara-ui[markdown]" "solara-server[starlette]"

Copy link

render bot commented Apr 5, 2024

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maartenbreddels and the rest of your teammates on Graphite Graphite

@maartenbreddels maartenbreddels marked this pull request as ready for review April 5, 2024 14:42
@iisakkirotko iisakkirotko force-pushed the master branch 2 times, most recently from c2951b9 to 8816e36 Compare April 5, 2024 14:59
@maartenbreddels maartenbreddels force-pushed the 04-05-refactor_separate_solara_into_a_meta_package_and_subpackages branch 4 times, most recently from 2b8f2cb to 21647c5 Compare April 5, 2024 18:55
@maartenbreddels maartenbreddels force-pushed the 04-05-refactor_separate_solara_into_a_meta_package_and_subpackages branch 3 times, most recently from f8b1350 to cebd58d Compare April 8, 2024 11:46
Copy link
Collaborator

@iisakkirotko iisakkirotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements! Mostly I just had some questions that we could discuss / clarify in comments.

.github/workflows/test.yaml Outdated Show resolved Hide resolved
@@ -542,7 +588,7 @@ jobs:
run: |
cd packages/solara-enterprise
openssl sha256 dist/*
hatch publish
# hatch publish
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should also be removed here

Suggested change
# hatch publish
hatch publish

.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
packages/pytest-ipywidgets/README.md Outdated Show resolved Hide resolved
packages/pytest-ipywidgets/pyproject.toml Show resolved Hide resolved
packages/solara-meta/pyproject.toml Outdated Show resolved Hide resolved
solara/cache.py Outdated Show resolved Hide resolved
packages/solara-meta/pyproject.toml Show resolved Hide resolved
@maartenbreddels maartenbreddels force-pushed the 04-05-refactor_separate_solara_into_a_meta_package_and_subpackages branch 4 times, most recently from f719411 to 9c7ae9c Compare April 8, 2024 14:22
This allows us to install solara-ui without solara-server and not
having to install all dependencies of solara-server.

This is useful when you need solara in the Jupyter environment and want
less dependencies installed.
@maartenbreddels maartenbreddels force-pushed the 04-05-refactor_separate_solara_into_a_meta_package_and_subpackages branch from 9c7ae9c to d3c8a52 Compare April 8, 2024 14:23
@maartenbreddels maartenbreddels merged commit cb28541 into master Apr 8, 2024
24 checks passed
maartenbreddels added a commit that referenced this pull request Apr 8, 2024
This allows us to install solara-ui without solara-server and not
having to install all dependencies of solara-server.

This is useful when you need solara in the Jupyter environment and want
less dependencies installed.
maartenbreddels added a commit that referenced this pull request Apr 8, 2024
This allows us to install solara-ui without solara-server and not
having to install all dependencies of solara-server.

This is useful when you need solara in the Jupyter environment and want
less dependencies installed.
maartenbreddels added a commit that referenced this pull request Apr 8, 2024
This allows us to install solara-ui without solara-server and not
having to install all dependencies of solara-server.

This is useful when you need solara in the Jupyter environment and want
less dependencies installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants