Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeframeExport - Uncaught error #1104

Closed
Splines opened this issue Aug 6, 2022 · 4 comments · Fixed by #1106
Closed

TimeframeExport - Uncaught error #1104

Splines opened this issue Aug 6, 2022 · 4 comments · Fixed by #1106
Assignees
Labels
bug Something isn't working

Comments

@Splines
Copy link

Splines commented Aug 6, 2022

Describe the bug
Appeared when trying to use the Commons Booking export over a too big span of months. Originally, only got this error:

Maximum execution time of 360 seconds exceeded

but now, we got this stacktrace a few days later when trying to export again (paths trimmed):

Ein Fehler vom Typ E_ERROR wurde in der Zeile 256 der Datei /wp-content/plugins/commonsbooking/src/View/TimeframeExport.php verursacht.
Fehlermeldung: Uncaught Error: Call to a member function getPost() on null in /wp-content/plugins/commonsbooking/src/View/TimeframeExport.php:256
Stack trace:
#0 /wp-content/plugins/commonsbooking/src/View/TimeframeExport.php(68): CommonsBooking\View\TimeframeExport::getTimeframeData()
#1 /wp-content/plugins/commonsbooking/src/Wordpress/Options/OptionsTab.php(126): CommonsBooking\View\TimeframeExport::exportCsv()
#2 /wp-includes/class-wp-hook.php(309): CommonsBooking\Wordpress\Options\OptionsTab::savePostOptions()
#3 /wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters()
#4 /wp-includes/plugin.php(476): WP_Hook->do_action()
#5 /wp-content/plugins/commonsbooking/vendor/cmb2/cmb2/includes/CMB2.php(880): do_action()
#6 /wp-content/plugins/commonsbooking/vendor/cmb2/cmb2/includes/CMB2.php(764): CMB2->after_save()
#7 /wp-content/plugins/commonsbooking/vendor/cmb2/cmb2/includes/CMB2_Options_Hookup.php(306): CMB2->save_fields()
#8 /wp-includes/class-wp-hook.php(307): CMB2_Options_Hookup->save_options()
#9 /wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters()
#10 /wp-includes/plugin.php(476): WP_Hook->do_action()
#11 /wp-admin/admin-post.php(85): do_action()
#12 {main}
  thrown

System details

  • WordPress-Version 6.0.1
  • Aktives Theme: Neve Child (Version 1.0.0)
  • Aktuelles Plugin: Commons Booking (Version 2.7.2) PHP-Version 8.0.18
@Splines Splines added the bug Something isn't working label Aug 6, 2022
@Splines
Copy link
Author

Splines commented Aug 6, 2022

Investigated a bit further: this issue only occurs when I try to export two specific months (September or October 2021). For all other months, it works fine (but still takes way too long in my opinion ;-)...

@Splines
Copy link
Author

Splines commented Aug 6, 2022

Error still occurs with these PHP settings:

  • version: 8.0.18
  • memory_limit: 1024M
  • max_execution_time: 600 seconds

@hansmorb hansmorb self-assigned this Aug 6, 2022
@hansmorb
Copy link
Contributor

hansmorb commented Aug 6, 2022

Danke für den Hinweis. Das hat etwas damit zu tun, dass bei euch Buchungen existieren zu denen aber entweder der zugehörige Standort oder der zugehörige Artikel fehlen. Das ist natürlich ein Bug. Der Fix ist fertig und muss noch getestet werden, kommt hoffentlich mit dem nächsten Release.

@hansmorb hansmorb added this to the Nächster Release milestone Aug 6, 2022
@hansmorb hansmorb linked a pull request Aug 6, 2022 that will close this issue
@Splines
Copy link
Author

Splines commented Aug 6, 2022

@hansmorb Super, vielen lieben Dank euch.

markus-mw added a commit that referenced this issue Aug 12, 2022
added checks for deleted items & locations fixes #1104
@hansmorb hansmorb removed this from the Nächster großer Release milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants