Add js and py files for API pageswithprop #185

PRISCILAVILEMEN · 2019-10-14T22:24:19Z

Created files that make requests to this API and printed the page titles as examples.

PRISCILAVILEMEN · 2019-10-14T22:35:17Z

Hi @brendajerop,
can you help me reviewing my first pr? :)

brendajerop

@PRISCILAVILEMEN Thank you for working on this!
Some general comments:

We need the PHP code as well, so please add it.
In your commit, make sure you add API:Pageswithprop to the readme files of Python, PHP and JavaScript folders.
Please provide a link to your sandbox page for this module.
We don't need to modify .gitignore.

PRISCILAVILEMEN · 2019-10-16T12:13:52Z

@PRISCILAVILEMEN Thank you for working on this!
Some general comments:

We need the PHP code as well, so please add it.

In your commit, make sure you add API:Pageswithprop to the readme files of Python, PHP and JavaScript folders.

Please provide a link to your sandbox page for this module.

We don't need to modify .gitignore.

@brendajerop , Thaks for the return..

I want to know
1 * We need the PHP code as well, so please add it.

I need to install something to run the code?

2- * Please provide a link to your sandbox page for this module.
https://www.mediawiki.org/wiki/User:Prisicilavilemen/Sandbox/API:Pageswithprop

Is to Add this link?

brendajerop · 2019-10-16T16:01:07Z

@brendajerop , Thaks for the return..

I want to know
1 * We need the PHP code as well, so please add it.

I need to install something to run the code?

Which operating system do you use?

2- * In your commit, make sure you add API:Pageswithprop to the readme files of Python, PHP and JavaScript folders.

about this task, I add the API, but the when click in the link, had error

I see that you have already added the files :)

3- * Please provide a link to your sandbox page for this module.
https://www.mediawiki.org/wiki/User:Prisicilavilemen/Sandbox/API:Pageswithprop

Is to Add this link?

Yes this is the link:)

PRISCILAVILEMEN · 2019-10-25T22:58:10Z

@brendajerop , I need to know where I input this link : https://www.mediawiki.org/wiki/User:Prisicilavilemen/Sandbox/API:Pageswithprop , Can you help me please ;)

brendajerop · 2019-10-27T05:26:52Z

@brendajerop , I need to know where I input this link : https://www.mediawiki.org/wiki/User:Prisicilavilemen/Sandbox/API:Pageswithprop , Can you help me please ;)

In the pull request description or the comment section. You've already linked to it so that's fine :)

brendajerop

@PRISCILAVILEMEN Thank you for working on this!
Since API:Pageswithprop is a GET request, the code should be auto-generated. How you do that is by adding its JSON schema to modules.json, then run python autogenerator.py to autogenerate the code. Please see the last statement in the contributing guidelines. However, I don't see the modules.json file in your pull reqest or the mediawikijs code. The pull request should contain changes to nine files:

modules.json
javascript/README.md
python/README.md
php/README.md
mediawikijs/README.md
python/get_pageswithprop.js(autogenerated)
mediawikijs/get_pageswithprop.js(autogenerated)
php/get_pageswithprop.js(autogenerated)
javascript/get_pageswithprop.js(autogenerated)

PRISCILAVILEMEN · 2019-10-28T16:32:18Z

@brendajerop hi,
I read this info at contributing.md (located on the root directory)
It says:

"For GET requests modules only, python, javascript and php sample code can be auto-generated by following the instructions below:"

As this file says can be auto-generated not should be auto-generated, so should I update this file to avoid further misleading interpretations?

PRISCILAVILEMEN · 2019-10-28T17:12:54Z

I made the changes, please check, and give me feedback, thanks

brendajerop · 2019-10-29T01:46:12Z

php/get_pageswithprop.php

+
+$output = curl_exec( $ch );
+
+if (curl_errno($ch)) { 


What does this if statement do? Do we need it?

This " if statement" existed to identify errors in curl and I forgot to remove it while fixing the SSL certificate issue.
take advantage and ask if they use any code editor or develop directly on the platform?

brendajerop · 2019-10-29T01:47:07Z

php/get_pageswithprop.php

+$ch = curl_init($url);
+
+curl_setopt( $ch, CURLOPT_RETURNTRANSFER, true );
+//curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);


Remove this comment:)

PRISCILAVILEMEN · 2019-10-29T23:06:36Z

@brendajerop , review my code ;) and give more feed backs

Best Regards

brendajerop · 2019-10-30T04:02:55Z

@PRISCILAVILEMEN Please rebase your changes on top of those in master. To do this, run git pull --rebase upstream master:)

PRISCILAVILEMEN

@PRISCILAVILEMEN Please rebase your changes on top of those in master. To do this, run git pull --rebase upstream master:)

Hello @brendajerop , I rebased my repo and fixed the merge conflicts. Could you verify , if everything is ok ?

PRISCILAVILEMEN · 2019-10-29T11:37:56Z

php/get_pageswithprop.php

+
+$output = curl_exec( $ch );
+
+if (curl_errno($ch)) { 


This " if statement" existed to identify errors in curl and I forgot to remove it while fixing the SSL certificate issue.
take advantage and ask if they use any code editor or develop directly on the platform?

brendajerop · 2019-10-31T02:44:48Z

@PRISCILAVILEMEN What do you get when you run git pull --rebase upstream master?

PRISCILAVILEMEN · 2019-10-31T13:14:37Z

@brendajerop , Sorry my rebase was not complete, but now I updated my branch and merged, please check. thanks

PRISCILAVILEMEN · 2019-10-31T13:37:05Z

@PRISCILAVILEMEN What do you get when you run `git pull --rebase upstream master?

My repo was a lot of commits behind, here is what I did before:

Rebased origin master from upstream master
Rebased origin mw-pageswithprop from origin master

But it seems that all the changes weren't there.

I did rebase again on my branch directly from upstream master, and it seems that now it merged correctly.

This project is my first experience with git, but I think I am getting used to it.

Can you please give another look at the PR? 😄

brendajerop · 2019-11-01T10:12:03Z

@PRISCILAVILEMEN I've left some feedback on the discussion page of your sandbox: https://www.mediawiki.org/wiki/User_talk:Prisicilavilemen/Sandbox/API:Pageswithprop :)

brendajerop reviewed Oct 15, 2019

View reviewed changes

brendajerop suggested changes Oct 27, 2019

View reviewed changes

brendajerop suggested changes Oct 29, 2019

View reviewed changes

PRISCILAVILEMEN commented Oct 30, 2019

View reviewed changes

PRISCILAVILEMEN and others added 2 commits November 1, 2019 08:02

API for pagewithprop on js and py

c78ac0b

Squash 138 commits into 1

46fcb10

brendajerop force-pushed the mw-pageswithprop branch from 4d312c7 to 46fcb10 Compare November 1, 2019 05:07

brendajerop merged commit fd8fbe1 into wikimedia:master Nov 1, 2019

PRISCILAVILEMEN deleted the mw-pageswithprop branch November 1, 2019 09:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add js and py files for API pageswithprop #185

Add js and py files for API pageswithprop #185

PRISCILAVILEMEN commented Oct 14, 2019

PRISCILAVILEMEN commented Oct 14, 2019

brendajerop left a comment •

edited

Loading

PRISCILAVILEMEN commented Oct 16, 2019 •

edited

Loading

brendajerop commented Oct 16, 2019

I need to install something to run the code?

about this task, I add the API, but the when click in the link, had error

PRISCILAVILEMEN commented Oct 25, 2019 •

edited

Loading

brendajerop commented Oct 27, 2019

brendajerop left a comment •

edited

Loading

PRISCILAVILEMEN commented Oct 28, 2019

PRISCILAVILEMEN commented Oct 28, 2019

brendajerop Oct 29, 2019

PRISCILAVILEMEN Oct 29, 2019

brendajerop Oct 29, 2019 •

edited

Loading

PRISCILAVILEMEN commented Oct 29, 2019

brendajerop commented Oct 30, 2019 •

edited

Loading

PRISCILAVILEMEN left a comment

PRISCILAVILEMEN Oct 29, 2019

brendajerop commented Oct 31, 2019

PRISCILAVILEMEN commented Oct 31, 2019

PRISCILAVILEMEN commented Oct 31, 2019 •

edited

Loading

brendajerop commented Nov 1, 2019

Add js and py files for API pageswithprop #185

Add js and py files for API pageswithprop #185

Conversation

PRISCILAVILEMEN commented Oct 14, 2019

PRISCILAVILEMEN commented Oct 14, 2019

brendajerop left a comment • edited Loading

Choose a reason for hiding this comment

PRISCILAVILEMEN commented Oct 16, 2019 • edited Loading

I need to install something to run the code?

brendajerop commented Oct 16, 2019

I need to install something to run the code?

about this task, I add the API, but the when click in the link, had error

PRISCILAVILEMEN commented Oct 25, 2019 • edited Loading

brendajerop commented Oct 27, 2019

brendajerop left a comment • edited Loading

Choose a reason for hiding this comment

PRISCILAVILEMEN commented Oct 28, 2019

PRISCILAVILEMEN commented Oct 28, 2019

brendajerop Oct 29, 2019

Choose a reason for hiding this comment

PRISCILAVILEMEN Oct 29, 2019

Choose a reason for hiding this comment

brendajerop Oct 29, 2019 • edited Loading

Choose a reason for hiding this comment

PRISCILAVILEMEN commented Oct 29, 2019

brendajerop commented Oct 30, 2019 • edited Loading

PRISCILAVILEMEN left a comment

Choose a reason for hiding this comment

PRISCILAVILEMEN Oct 29, 2019

Choose a reason for hiding this comment

brendajerop commented Oct 31, 2019

PRISCILAVILEMEN commented Oct 31, 2019

PRISCILAVILEMEN commented Oct 31, 2019 • edited Loading

brendajerop commented Nov 1, 2019

brendajerop left a comment •

edited

Loading

PRISCILAVILEMEN commented Oct 16, 2019 •

edited

Loading

PRISCILAVILEMEN commented Oct 25, 2019 •

edited

Loading

brendajerop left a comment •

edited

Loading

brendajerop Oct 29, 2019 •

edited

Loading

brendajerop commented Oct 30, 2019 •

edited

Loading

PRISCILAVILEMEN commented Oct 31, 2019 •

edited

Loading