-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP / RFC: Modules #97
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwicke
force-pushed
the
modules
branch
2 times, most recently
from
December 29, 2014 22:53
c21325c
to
68a3854
Compare
- Make domains top-level, with /v1 and /sys below. Rationale: Domains will want to version their APIs independently. Domains are unlikely to go away, so having them at the top-level does not really introduce any restrictions. Having a private `/{domain}/sys` in parallel with `/{domian}/v1/` (public API) is shorter and lets us version the internal interface independently (using sys2 for example). - Sketch a global config. Make it domain-oriented, so that we can build up routing around that. Can use yaml features to reuse / share repetitive elements, or build up the per-domain config from feature-oriented configs like InitializeSettings.php in production.
1 similar comment
I have merged this branch into wikimedia/restbase:modules, so we can continue working on it. Hence, I'm closing this PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP branch to work out a design for https://phabricator.wikimedia.org/T76883. Do not merge just yet.