Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP / RFC: Modules #97

Closed
wants to merge 2 commits into from
Closed

WIP / RFC: Modules #97

wants to merge 2 commits into from

Conversation

gwicke
Copy link
Member

@gwicke gwicke commented Dec 29, 2014

This is a WIP branch to work out a design for https://phabricator.wikimedia.org/T76883. Do not merge just yet.

@gwicke gwicke force-pushed the modules branch 2 times, most recently from c21325c to 68a3854 Compare December 29, 2014 22:53
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling f742e4a on gwicke:modules into 0ce4e64 on wikimedia:master.

- Make domains top-level, with /v1 and /sys below. Rationale: Domains will
  want to version their APIs independently. Domains are unlikely to go away,
  so having them at the top-level does not really introduce any restrictions.
  Having a private `/{domain}/sys` in parallel with `/{domian}/v1/` (public
  API) is shorter and lets us version the internal interface independently
  (using sys2 for example).

- Sketch a global config. Make it domain-oriented, so that we can build up
  routing around that. Can use yaml features to reuse / share repetitive
  elements, or build up the per-domain config from feature-oriented configs
  like InitializeSettings.php in production.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling 97333c0 on gwicke:modules into 484a46a on wikimedia:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling c815ac4 on gwicke:modules into c075063 on wikimedia:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling c815ac4 on gwicke:modules into c075063 on wikimedia:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling 1116c37 on gwicke:modules into c075063 on wikimedia:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.86%) when pulling 4ad2247 on gwicke:modules into 044a225 on wikimedia:master.

@d00rman
Copy link
Contributor

d00rman commented Jan 13, 2015

I have merged this branch into wikimedia/restbase:modules, so we can continue working on it. Hence, I'm closing this PR.

@d00rman d00rman closed this Jan 13, 2015
@d00rman d00rman mentioned this pull request Jan 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants