-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final API tweaks #4651
Merged
Merged
Final API tweaks #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonisevener
added
the
Dependent PR
PR is dependent on another PR - merge dependent PR first and update branch before merging
label
Oct 6, 2023
- Fix missing wiki_id when going directly to in-app web view - Fix missing campaign banner ID when going to in-app web view
tonisevener
removed
the
Dependent PR
PR is dependent on another PR - merge dependent PR first and update branch before merging
label
Oct 9, 2023
Donor Experiences - add analytics
mazevedofs
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T348278
https://phabricator.wikimedia.org/T345847
Reverting https://phabricator.wikimedia.org/T345852
Notes
These are some additional tweaks needed against the FR Tech endpoints, as well as tweaks needed against the new campaign configs:
utm_source
value from campaign) tosubmitPayment
API call.submitPayment
API callI'm going to mark this as Draft in case there are any final tweaks from FR Tech. This is dependent on #4649.
Test Steps