Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final API tweaks #4651

Merged
merged 30 commits into from
Oct 9, 2023
Merged

Final API tweaks #4651

merged 30 commits into from
Oct 9, 2023

Conversation

tonisevener
Copy link
Collaborator

@tonisevener tonisevener commented Oct 6, 2023

Phabricator:
https://phabricator.wikimedia.org/T348278
https://phabricator.wikimedia.org/T345847
Reverting https://phabricator.wikimedia.org/T345852

Notes

These are some additional tweaks needed against the FR Tech endpoints, as well as tweaks needed against the new campaign configs:

  • Remove injection scripts
  • Remove Payments API Key from calls to FR Tech endpoints
  • Add banner ID (when coming from campaign modal...utm_source value from campaign) to submitPayment API call.
  • Add app version to submitPayment API call
  • Updated config mock with latest from test wiki campaign config. Add Italian campaign ID as an ID we're targeting to receive the new donor experience.

I'm going to mark this as Draft in case there are any final tweaks from FR Tech. This is dependent on #4649.

Test Steps

  1. Make these local changes to mock endpoints on staging - 6eaaa0b
  2. Change device region to Italy
  3. Run app on Staging. Background app, foreground, pull to refresh on Explore feed.
  4. Go to an article on IT Wikipedia. Confirm you see campaign modal in Italian. Tap "Donate". Tap "Apple Pay".
  5. Line break here.
  6. On donate form, go through donation flow until app tries to submit. Check at line break and be sure banner ID and app version is populated.

@tonisevener tonisevener added the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Oct 6, 2023
@tonisevener tonisevener marked this pull request as draft October 6, 2023 16:40
@tonisevener tonisevener marked this pull request as ready for review October 9, 2023 16:22
@tonisevener tonisevener changed the title [HOLD] Final API tweaks Final API tweaks Oct 9, 2023
Base automatically changed from new-fundraising-banner to main October 9, 2023 16:35
@tonisevener tonisevener removed the Dependent PR PR is dependent on another PR - merge dependent PR first and update branch before merging label Oct 9, 2023
@mazevedofs mazevedofs merged commit 75a7c3d into main Oct 9, 2023
2 checks passed
@mazevedofs mazevedofs deleted the fr-tech-tweaks branch October 9, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants