Log preset_selected in the applepay_ui_confirm event #4658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T346086
Link to more discussion: https://docs.google.com/presentation/d/1vZZwXb0rOGFlqvSy5PxxqRVy83ORPBAwYVHisfp4_o0/edit?disco=AAAA6dNQPAg
Notes
Analytics wants to be able to track if a user entered a custom amount in the donate form. I had difficulty hooking into this from the SwiftUI currency textfield without a lot of programmatic misfires, so instead we are sending an additional flag upon authorization of the payment sheet indicating if they have an amount preset button selected.
Test Steps
Local-only changes: Add
WKDataEnvironment.current.basicService = WKMockBasicService()
to this area to fake all the payment endpoints.In Wallet app, add Test Apple Pay card.
action_data
haspreset_selected:true
if an amount button is selected, andpreset_selected:false
if no amount button is selected.