Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Web donate urls #4854

Merged
merged 3 commits into from
May 16, 2024
Merged

Update Web donate urls #4854

merged 3 commits into from
May 16, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T350919

Notes

This PR updates the web donate urls:

From settings, it updates the utm_source value to appmenu, and adds app_version.
From a campaign modal, it adds app_version.

Test Steps

  1. On device, change device region to Japan. Change device date to May 31st.
  2. Add line break here in Xcode.
  3. Fresh install on Staging app. On Explore feed, background, forground, then pull to refresh to fetch campaigns.
  4. Visit an article on EN or JA Wikipedia. Campaign modal should appear. Tap Donate button. If needed choose Other payment method.
  5. You should hit line break. Inspect the url, confirm app_version is appended to it.
  6. Go to Settings. Tap Donate method. If needed choose Other payment method.
  7. You should hit line break. Inspect the url, confirm app_version is appended to it, and utm_source = appmenu.

@mazevedofs mazevedofs merged commit 2672a2b into main May 16, 2024
4 checks passed
@mazevedofs mazevedofs deleted the T350919 branch May 16, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants