-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing New Model Performance #62
Comments
Hey @DroneMesh, |
HI Wil, Using the PPO1 Example all is working well and checkpoints are being generated correctly. However, I am unable to test the model and graph its performance.
The problem with this now is the |
Hi Wil, You can close this I ended up using the latest Stable-Baselines and modified the NF1 example slightly. Once I finish and clean up the code I will issue a pull request. For a new NF1 example that is compatible with the latest Stable-Baselines along with the script to test its performance where it graphs motor output and target setpoints with the error. |
This project has only provided code and examples for OpenAI Baselines so if you are using Stable Baselines that's probably why it didn't work. Be sure to thoroughly read https://github.com/wil3/gymfc/blob/master/CONTRIBUTING.md before opening a PR. PRs are tied to issues so its up to you when you want to close an issue you open. |
I was using your openAI Baselines branch but then i gave up on it and now i
am using stable-baselines is actually working really well with a ton more
features for debugging and custom callbacks.
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon>
Virus-free.
www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
…On Mon, Jun 1, 2020 at 7:54 PM Wil Koch ***@***.***> wrote:
This project has only provided code and examples for OpenAI Baselines so
if you are using Stable Baselines that's probably why it didn't work. Be
sure to thoroughly read
https://github.com/wil3/gymfc/blob/master/CONTRIBUTING.md before opening
a PR. PRs are tied to issues so its up to you when you want to close an
issue you open.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#62 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHYGCF6AZGAAMMZ3O52L2ETRUPTMDANCNFSM4NOEM4GA>
.
|
Hi @DroneMesh since this opened issue was due to code that is supported in the repo I'm going to close it since the PR you briefly mentioned is a separate issue. If you are still interested in contributing and submitting a PR please open a feature request issue outlining the intended changes for that specific PR. To add a policy for an other trainer you'll just need a new policy here and an example of how that trainer is instantiated like the OpenAI Baselines example. In fact the baselinespolicy.py can really be generalized to a Tensorflow checkpoint policy which is inheritted depending on the different tensor names for the input and output. I have a Tensorforce policy I plan to add soon too. I've also added evaluation scripts and plotters in the examples directory that may help you. |
Hi Wil,
I have setup your latest gymfc with the nf1 example all is working, However previously we were able to run
pi.act(False, ob=ob)[0]
to test the model and do our own custom graphing but with your new baselines repo something has changed can you clarify how to run the recent model manually to test it.Thanks
The text was updated successfully, but these errors were encountered: