-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix app freezing (fixes: #93) #145
Conversation
I am not a c++ programmer, and I am not sure what I did here. But this fixes issue wilix-team#93.
I'm closing this for now. Feel free to reopen it if you want to. |
@Djiit Why it has been closed? |
Hey @Luke265, do you understand why this PR was closed? Was there some issue with it that might not be apparent for me and sentialx? Or was its closure confusing for you too? |
@Wizek Sorry, I don't know why this PR was closed. I had no issues, so far, using iohook with this PR. |
Hi guys, Sorry if I closed this too soon. I thought it was not necessary and it didn't have any activity. |
Thanks @Djiit for reopening! So, in the interest of moving forward with this issue getting fixed, I tried out this patch. However, the mouse-freezing is still present when I ran this test:
Even when I set
You can find my repro-repo over here: https://github.com/Wizek/iohook-test. Just
Could you @Luke265 do the above test and tell me if your mouse lags after that code runs on Windows, preferably Windows 10? Also, @Djiit, could you also do this just so you can see how bad this bug is? |
As this is still not fixed, I'm switching over to something that seems to work better: |
I also get the freezing when running multiple iohook apps at the same time. I haven't been able to try the PR but I support the effort. |
Closing it regarding #294 |
When running multiple apps with iohook, mouse/key inputs becomes very laggy, sometimes even completely frozen.
Description
I am not a c++ programmer, and I am not exactly sure what I did here.
Motivation and Context
See #93
How Has This Been Tested?
With the patch iohook installs locally on Windows 10.
Screenshots (if appropriate):
Types of changes
Checklist: