Skip to content
This repository has been archived by the owner on May 22, 2022. It is now read-only.

MSA viewer is not loading... #260

Closed
l-singh-biomsu opened this issue Aug 9, 2021 · 6 comments
Closed

MSA viewer is not loading... #260

l-singh-biomsu opened this issue Aug 9, 2021 · 6 comments

Comments

@l-singh-biomsu
Copy link

Hello,
I am using Ubuntu 18.04
Chromium v92.0.4515.131
MSA vier is not laoding. It crushes with error Uncaught TypeError: seqs.on is not a function.
Please fix this bug soon, I rely on it!

@JacobPorter
Copy link

JacobPorter commented Aug 10, 2021

This seems related to Issue #259. I am a developer for bv-brc.org, and we use this viewer. It has recently stopped working for us when Firefox and Chromium were upgraded to the latest releases. Chrome rendering stopped working in version 92.0.4515.131, and Firefox rendering stopped working on version 90.0.2.

@l-singh-biomsu
Copy link
Author

Is there any ideas how to fix the issue?
I just tried this workaround from the isuue #257. Some configurations are missed, but it works.

@dmachi
Copy link

dmachi commented Sep 1, 2021

@l-singh-biomsu The issue is the 'at' in seqs portion of https://github.com/wilzbach/stat.seqs/blob/master/lib/index.js#L52

at() is now a method of JS Arrays on Chrome/FF (but not on Safari and other browsers yet) and so this check doesnt' do what is expected.

We replaced this with a check like '_byId' in seqs that works for our particular case because of the data we're initially passing in, but I am not sure if it is a valid general solution for others. If not a different check will need to be applied there.

molsim pushed a commit to intbio/histonedb that referenced this issue Sep 9, 2021
@guignonv
Copy link

guignonv commented Sep 10, 2021

How about checking 'on' instead of '_byId' since it's that method which is called?

@websemantics
Copy link

Building on @dmachi's comment, add the following before instantiating msa

delete Array.prototype.at 

Not ideal but it works

@huy-nguyen
Copy link

I've made a fix for this on my own fork that I think is more robust. niaid@e82512e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants