Allow to safe_dump with OrderedDict instances #5
Conversation
| @@ -18,6 +18,7 @@ def map_constructor(loader, node): | |||
|
|
|||
| pyyaml.add_representer(dict, map_representer) | |||
| pyyaml.add_representer(OrderedDict, map_representer) | |||
| pyyaml.add_representer(OrderedDict, map_representer, Dumper=pyyaml.dumper.SafeDumper) | |||
There was a problem hiding this comment.
Interesting, why are both of the above lines needed?
There was a problem hiding this comment.
pyyaml.add_representer works on the Dumper class obj passed into it.
There was a problem hiding this comment.
Okay, but if I remove line 20 everything still works for me. Do you have a test that fails when that line is removed?
There was a problem hiding this comment.
Really? That's odd. For me, the existing test_dump and test_dump_all fail without line 20. Could you send me your pip freeze.
There was a problem hiding this comment.
ah, "works for me" is not "running the oyaml tests" :-) All good, if you have tests that prove it's needed, that's weird, but okay :-)
There was a problem hiding this comment.
OK. I've released v0.3 to warehouse (the new PyPI).
resolves #4