Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds SFTP support for fileconveyor #57

Closed
wants to merge 3 commits into from

Conversation

jacobSingh
Copy link
Contributor

Requires percona, can be used just like the ftp transport. Can accept parameter or will use ssh agent of current session.

@wimleers
Copy link
Owner

You say "percona", but I assume that you really mean "paramiko" (http://www.lag.net/paramiko/).

I added some basic documentation: 99331c3. Could you please confirm that it is correct?

It has been merged (but github didn't detect it because the default merge mechanism failed, I had to use the patch approach documented here: http://help.github.com/pull-requests/).

@wimleers wimleers closed this Apr 16, 2011
@jacobSingh
Copy link
Contributor Author

Yes, just a brain fart there :)

The documentation link is 99331c3 . (the dot got added to yours).

It might be worth noting that it will use the SSH agent if you don't specify the key.

@wimleers
Copy link
Owner

If you don't specify a key, nor a password, you mean? Could you just roll a quick patch (you don't have to create a fork)?

@jacobSingh
Copy link
Contributor Author

Hah, I think I screwed up the branching / forking stuff... anyway here's a patch:

diff --git a/code/README.txt b/code/README.txt
index a81969f..e44961a 100644
--- a/code/README.txt
+++ b/code/README.txt
@@ -247,7 +247,6 @@ Available settings:
 - url
 - port
 - path
-- key
 
 
 Transporter: SFTP (sftp)
@@ -261,6 +260,7 @@ Available settings:
 - url
 - port
 - path
+- key (if not provided, fileconveyor will attempt to connect via keys from your ssh-agent.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants